From: Dan Carpenter <dan.carpenter@oracle.com>
To: shahar.s.matityahu@intel.com
Cc: linux-wireless@vger.kernel.org
Subject: [bug report] iwlwifi: dbg: support multiple dumps in legacy dump flow
Date: Wed, 6 May 2020 17:46:57 +0300 [thread overview]
Message-ID: <20200506144657.GA115454@mwanda> (raw)
Hello Shahar S Matityahu,
This is a semi-automatic email about new static checker warnings.
The patch 7a99c877ae8e: "iwlwifi: dbg: support multiple dumps in
legacy dump flow" from Apr 17, 2020, leads to the following Smatch
complaint:
drivers/net/wireless/intel/iwlwifi/fw/dbg.c:2182 iwl_fw_free_dump_desc()
error: we previously assumed 'desc' could be null (see line 2179)
drivers/net/wireless/intel/iwlwifi/fw/dbg.c
2178 {
2179 if (desc && *desc != &iwl_dump_desc_assert)
^^^^
New check for NULL
2180 kfree(*desc);
2181
2182 *desc = NULL;
^^^^^
New unchecked dereference.
2183 fwrt->dump.lmac_err_id[0] = 0;
2184 if (fwrt->smem_cfg.num_lmacs > 1)
regards,
dan carpenter
reply other threads:[~2020-05-06 14:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506144657.GA115454@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-wireless@vger.kernel.org \
--cc=shahar.s.matityahu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).