From: Dan Carpenter <dan.carpenter@oracle.com>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: vt6656: vnt_beacon_xmit use extra_tx_headroom.
Date: Mon, 18 May 2020 15:39:44 +0300 [thread overview]
Message-ID: <20200518123944.GI2078@kadam> (raw)
In-Reply-To: <5f00d319-9242-65b2-d100-dcfe9b0e32be@gmail.com>
On Sat, May 16, 2020 at 11:39:34AM +0100, Malcolm Priestley wrote:
> Create room for vnt_tx_short_buf_head in sk_buff and vnt_tx_usb_header.
>
> The struct ieee80211_mgmt is not longer in the header and is at
> the initial skb->data point.
I feel like the SubmittingPatches guidelines on verb tenses and not
saying "this patch" or "I" has got everyone so worried that it's like
playing Taboo. Do you mean that the struct moved before or after we
aply *this patch*?
>
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
I can't understand the point of this patch at all. Is it a fix or a
clean up? If I had to guess from the subjec, I would say it's a
performance improvement but I don't know.
regards,
dan carpenter
next prev parent reply other threads:[~2020-05-18 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 10:39 [PATCH 2/4] staging: vt6656: vnt_beacon_xmit use extra_tx_headroom Malcolm Priestley
2020-05-18 12:39 ` Dan Carpenter [this message]
2020-05-18 20:42 ` Malcolm Priestley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518123944.GI2078@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).