From: "Pali Rohár" <pali@kernel.org>
To: Amitkumar Karwar <amitkarwar@gmail.com>,
Ganapathi Bhat <ganapathi.bhat@nxp.com>,
Xinming Hu <huxinming820@gmail.com>
Cc: "Kalle Valo" <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
"Marek Behún" <marek.behun@nic.cz>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mwifiex: Parse all API_VER_ID properties
Date: Thu, 28 May 2020 12:28:58 +0200 [thread overview]
Message-ID: <20200528102858.riwsja5utqix6wqo@pali> (raw)
In-Reply-To: <20200521123444.28957-1-pali@kernel.org>
On Thursday 21 May 2020 14:34:44 Pali Rohár wrote:
> During initialization of SD8997 wifi chip kernel prints warnings:
>
> mwifiex_sdio mmc0:0001:1: Unknown api_id: 3
> mwifiex_sdio mmc0:0001:1: Unknown api_id: 4
>
> This patch adds support for parsing all api ids provided by SD8997
> firmware.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/net/wireless/marvell/mwifiex/cmdevt.c | 17 +++++++++++++++--
> drivers/net/wireless/marvell/mwifiex/fw.h | 2 ++
> 2 files changed, 17 insertions(+), 2 deletions(-)
>
Hello! Could you please look at this trivial patch?
> diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
> index 7e4b8cd52..589cc5eb1 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
> @@ -1581,8 +1581,21 @@ int mwifiex_ret_get_hw_spec(struct mwifiex_private *priv,
> adapter->fw_api_ver =
> api_rev->major_ver;
> mwifiex_dbg(adapter, INFO,
> - "Firmware api version %d\n",
> - adapter->fw_api_ver);
> + "Firmware api version %d.%d\n",
> + adapter->fw_api_ver,
> + api_rev->minor_ver);
> + break;
> + case UAP_FW_API_VER_ID:
> + mwifiex_dbg(adapter, INFO,
> + "uAP api version %d.%d\n",
> + api_rev->major_ver,
> + api_rev->minor_ver);
> + break;
> + case CHANRPT_API_VER_ID:
> + mwifiex_dbg(adapter, INFO,
> + "channel report api version %d.%d\n",
> + api_rev->major_ver,
> + api_rev->minor_ver);
> break;
> default:
> mwifiex_dbg(adapter, FATAL,
> diff --git a/drivers/net/wireless/marvell/mwifiex/fw.h b/drivers/net/wireless/marvell/mwifiex/fw.h
> index a415d73a7..6f86f5b96 100644
> --- a/drivers/net/wireless/marvell/mwifiex/fw.h
> +++ b/drivers/net/wireless/marvell/mwifiex/fw.h
> @@ -1052,6 +1052,8 @@ struct host_cmd_ds_802_11_ps_mode_enh {
> enum API_VER_ID {
> KEY_API_VER_ID = 1,
> FW_API_VER_ID = 2,
> + UAP_FW_API_VER_ID = 3,
> + CHANRPT_API_VER_ID = 4,
> };
>
> struct hw_spec_api_rev {
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-05-28 10:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 12:34 [PATCH] mwifiex: Parse all API_VER_ID properties Pali Rohár
2020-05-28 10:28 ` Pali Rohár [this message]
2020-05-29 3:47 ` [EXT] " Ganapathi Bhat
2020-05-29 17:41 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528102858.riwsja5utqix6wqo@pali \
--to=pali@kernel.org \
--cc=amitkarwar@gmail.com \
--cc=davem@davemloft.net \
--cc=ganapathi.bhat@nxp.com \
--cc=huxinming820@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox