From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CA5EC433E0 for ; Fri, 29 May 2020 17:11:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57D6A20723 for ; Fri, 29 May 2020 17:11:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="uLFuPvEe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbgE2RLs (ORCPT ); Fri, 29 May 2020 13:11:48 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:47547 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgE2RLs (ORCPT ); Fri, 29 May 2020 13:11:48 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1590772307; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=PwkZeuyBpewwPeV1Sxl1oUuJLFs8EercjU1m0Po6ejo=; b=uLFuPvEeMx2BtRIhzlR0y/S0NIcwRNtLpw6VHGgXVGs6yFIp4wrsifv4b/nlki5wLSX2EO6k 1mWaZJpKLh7kouOQNZTd+uF/w36cTBbaBirHd5swD7wTtJS+Ac0O+C9OOIXmBHbc+RKSNcTg Pg1GDICQMKKqNPYNiXz6+l+uEKA= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 5ed1423c5086732481ed0f68 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 29 May 2020 17:11:24 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9E866C433CB; Fri, 29 May 2020 17:11:24 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 14A1AC433C9; Fri, 29 May 2020 17:11:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 14A1AC433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] Revert "rtw88: no need to set registers for SDIO" From: Kalle Valo In-Reply-To: <20200520055350.23328-1-yhchuang@realtek.com> References: <20200520055350.23328-1-yhchuang@realtek.com> To: Cc: , User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200529171124.9E866C433CB@smtp.codeaurora.org> Date: Fri, 29 May 2020 17:11:24 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org wrote: > From: Yan-Hsuan Chuang > > This reverts commit 07d0f5534935e2daf63a4e1012af13d68e089fed. > > For rtw88 driver, the SDIO is going to be supported, so there is > no need to remove the SDIO related power sequence settings. And > while the power sequence parser will pass in the mask of the HCI, > the SDIO part will not be used to set registers accordingly. > > Moreover, the power sequence table is released as a whole package, > so the next time if we are going to update, the SDIO settings will > be overwritten. So, revert this now. > > Signed-off-by: Yan-Hsuan Chuang Patch applied to wireless-drivers-next.git, thanks. dba5a189bf61 Revert "rtw88: no need to set registers for SDIO" -- https://patchwork.kernel.org/patch/11559339/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches