From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A49AC433E1 for ; Tue, 14 Jul 2020 17:54:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3E7E2256C for ; Tue, 14 Jul 2020 17:54:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="wYq833Ry" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729010AbgGNRyM (ORCPT ); Tue, 14 Jul 2020 13:54:12 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:37324 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727028AbgGNRyK (ORCPT ); Tue, 14 Jul 2020 13:54:10 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594749250; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=L1XYMeZq8mr3PCvQ6HmM+i0YLB7CkoBZ5IiOpY3WDpg=; b=wYq833RyZxtrrcQ83vvdngioNBSvyR5kjysFtHsDtqPBdChbv3rJ7+3uIwl9devMBDvSl13n QpwUR3zNItzM6eeqj2YSWWD77ln7u05E5k8n8raCO7OGRN7/T89h6pYo5s/zeYqcZ2UBR0U1 3KF2NEmr3YwhhXmNCx+FLqVCIFE= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n17.prod.us-east-1.postgun.com with SMTP id 5f0df12a03c8596cdbb3773d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 14 Jul 2020 17:53:46 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E4B7BC4339C; Tue, 14 Jul 2020 17:53:44 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 04878C433CB; Tue, 14 Jul 2020 17:53:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 04878C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wilc1000: let wilc_mac_xmit() return NETDEV_TX_OK From: Kalle Valo In-Reply-To: <20200629104009.84077-1-luc.vanoostenryck@gmail.com> References: <20200629104009.84077-1-luc.vanoostenryck@gmail.com> To: Luc Van Oostenryck Cc: Nicolas Ferre , Adham Abozaeid , Ajay Singh , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Luc Van Oostenryck User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200714175344.E4B7BC4339C@smtp.codeaurora.org> Date: Tue, 14 Jul 2020 17:53:44 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type defining 'NETDEV_TX_OK' but this > driver returns '0' instead of 'NETDEV_TX_OK'. > > Fix this by returning 'NETDEV_TX_OK' instead of '0'. > > Signed-off-by: Luc Van Oostenryck Patch applied to wireless-drivers-next.git, thanks. cce0e08301fe wilc1000: let wilc_mac_xmit() return NETDEV_TX_OK -- https://patchwork.kernel.org/patch/11632291/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches