From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFA3CC433E4 for ; Wed, 15 Jul 2020 08:35:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC26B206F5 for ; Wed, 15 Jul 2020 08:35:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="NQcMffOy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730216AbgGOIf1 (ORCPT ); Wed, 15 Jul 2020 04:35:27 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:35848 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729243AbgGOIfZ (ORCPT ); Wed, 15 Jul 2020 04:35:25 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594802124; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=h+ddvCJz2+eIJsGbCmIQ+4rTo2OVcXt1uczscOrvqEg=; b=NQcMffOy/WmElDgdrJppP0tLt/CtPTrBQqxPEvyKVTWqxDzysDYE9iDOmioaUARZX4fKeE4W 3XcrAL18rSy6zsU/p26KNWPcoJUrSa8q0Dn3wYGtrkXmg+5vKmq+ft4cis8IY005SYotuK1B ytfd+esvMCrUuni/YxyLGAAsWJ8= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n14.prod.us-west-2.postgun.com with SMTP id 5f0ebfb7b35196d59d30e7af (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 15 Jul 2020 08:35:03 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E84A2C433B1; Wed, 15 Jul 2020 08:35:02 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id ED8CBC433CB; Wed, 15 Jul 2020 08:34:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org ED8CBC433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wlcore: mesh: handle failure case of pm_runtime_get_sync From: Kalle Valo In-Reply-To: <20200605032733.49846-1-navid.emamdoost@gmail.com> References: <20200605032733.49846-1-navid.emamdoost@gmail.com> To: Navid Emamdoost Cc: "David S. Miller" , Johannes Berg , Thomas Gleixner , Greg Kroah-Hartman , Hari Nagalla , "Jason A. Donenfeld" , Emmanuel Grumbach , Maital Hahn , Fuqian Huang , Tony Lindgren , Navid Emamdoost , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, emamd001@umn.edu, wu000273@umn.edu, kjlu@umn.edu, smccaman@umn.edu User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200715083502.E84A2C433B1@smtp.codeaurora.org> Date: Wed, 15 Jul 2020 08:35:02 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Navid Emamdoost wrote: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count. Call pm_runtime_put if > pm_runtime_get_sync fails. > > Signed-off-by: Navid Emamdoost Already fixed by another patch. Patch set to Rejected. -- https://patchwork.kernel.org/patch/11588923/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches