* [PATCH] rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path
@ 2020-07-23 16:32 Colin King
2020-07-24 5:14 ` Pkshih
2020-08-02 14:54 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2020-07-23 16:32 UTC (permalink / raw)
To: Ping-Ke Shih, Kalle Valo, David S . Miller, Jakub Kicinski,
linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variables ant_num and single_ant_path are being initialized with a
value that is never read and are being updated later with a new value.
The initializations are redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
index a4940a3842de..4949f99844b5 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
@@ -1318,7 +1318,7 @@ bool exhalbtc_bind_bt_coex_withadapter(void *adapter)
{
struct rtl_priv *rtlpriv = adapter;
struct btc_coexist *btcoexist = rtl_btc_coexist(rtlpriv);
- u8 ant_num = 2, chip_type, single_ant_path = 0;
+ u8 ant_num, chip_type, single_ant_path;
if (!btcoexist)
return false;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path
2020-07-23 16:32 [PATCH] rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path Colin King
@ 2020-07-24 5:14 ` Pkshih
2020-08-02 14:54 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Pkshih @ 2020-07-24 5:14 UTC (permalink / raw)
To: linux-wireless@vger.kernel.org, colin.king@canonical.com,
kvalo@codeaurora.org, netdev@vger.kernel.org, davem@davemloft.net,
kuba@kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
On Thu, 2020-07-23 at 17:32 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variables ant_num and single_ant_path are being initialized with a
> value that is never read and are being updated later with a new value.
> The initializations are redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Thank you
> ---
> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> index a4940a3842de..4949f99844b5 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> @@ -1318,7 +1318,7 @@ bool exhalbtc_bind_bt_coex_withadapter(void *adapter)
> {
> struct rtl_priv *rtlpriv = adapter;
> struct btc_coexist *btcoexist = rtl_btc_coexist(rtlpriv);
> - u8 ant_num = 2, chip_type, single_ant_path = 0;
> + u8 ant_num, chip_type, single_ant_path;
>
> if (!btcoexist)
> return false;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path
2020-07-23 16:32 [PATCH] rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path Colin King
2020-07-24 5:14 ` Pkshih
@ 2020-08-02 14:54 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-08-02 14:54 UTC (permalink / raw)
To: Colin King
Cc: Ping-Ke Shih, David S . Miller, Jakub Kicinski, linux-wireless,
netdev, kernel-janitors, linux-kernel
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variables ant_num and single_ant_path are being initialized with a
> value that is never read and are being updated later with a new value.
> The initializations are redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
56b06d4da812 rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path
--
https://patchwork.kernel.org/patch/11681295/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-02 14:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-23 16:32 [PATCH] rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path Colin King
2020-07-24 5:14 ` Pkshih
2020-08-02 14:54 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).