From: Dan Carpenter <dan.carpenter@oracle.com>
To: Walter Harms <wharms@bfs.de>
Cc: Kalle Valo <kvalo@codeaurora.org>,
Jakub Kicinski <kuba@kernel.org>,
Jouni Malinen <jouni@qca.qualcomm.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] ath6kl: prevent potential array overflow in ath6kl_add_new_sta()
Date: Fri, 14 Aug 2020 14:17:54 +0300 [thread overview]
Message-ID: <20200814111753.GQ1793@kadam> (raw)
In-Reply-To: <61e34f670a4845f8b1cbf6f6013f8a35@bfs.de>
On Fri, Aug 14, 2020 at 08:49:43AM +0000, Walter Harms wrote:
> nitpicking:
>
> the debugtrace will give the impression that the function is
> running. perhaps it is more clever to have this after the check.
>
The debug is more useful they way I did it. Otherwise it doesn't
print anything. This is also the normal way to do this sort of
debugging.
regards,
dan carpenter
next prev parent reply other threads:[~2020-08-14 11:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 14:13 [PATCH] ath6kl: prevent potential array overflow in ath6kl_add_new_sta() Dan Carpenter
2020-08-14 8:49 ` AW: " Walter Harms
2020-08-14 10:29 ` Kalle Valo
2020-08-14 11:17 ` Dan Carpenter [this message]
2020-08-17 10:22 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814111753.GQ1793@kadam \
--to=dan.carpenter@oracle.com \
--cc=jouni@qca.qualcomm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).