From: Sergey Matyukevich <geomatsi@gmail.com>
To: Tamizh Chelvam <tamizhr@codeaurora.org>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iw: add TID specific Tx bitrate configuration
Date: Thu, 20 Aug 2020 10:49:26 +0300 [thread overview]
Message-ID: <20200820074926.GA2255@curiosity> (raw)
In-Reply-To: <1597903916-8674-1-git-send-email-tamizhr@codeaurora.org>
Hello Tamizh,
> Add TID specific Tx bitrate configuration by using
> handle_bitrates already APIs.
>
> Examples:
> $ iw dev wlan0 peer xx:xx:xx:xx:xx:xx tids 0x2 bitrates auto
> $ iw dev wlan0 peer xx:xx:xx:xx:xx:xx tids 0x2 bitrates limit vht-mcs-5 4:9
>
> Signed-off-by: Tamizh Chelvam <tamizhr@codeaurora.org>
> ---
> bitrate.c | 27 ++++++++++++++++++++-------
> interface.c | 34 +++++++++++++++++++++++++++++++++-
> iw.h | 3 +++
> 3 files changed, 56 insertions(+), 8 deletions(-)
...
> COMMAND(set, tidconf, "[peer <MAC address>] tids <mask> [override] [sretry <num>] [lretry <num>] "
> - "[ampdu [on|off]] [amsdu [on|off]] [noack [on|off]] [rtscts [on|off]]",
> + "[ampdu [on|off]] [amsdu [on|off]] [noack [on|off]] [rtscts [on|off]]"
> + "[bitrates <type [auto|fixed|limit]> [legacy-<2.4|5> <legacy rate in Mbps>*] [ht-mcs-<2.4|5> <MCS index>*]"
> + " [vht-mcs-<2.4|5> <NSS:MCSx,MCSy... | NSS:MCSx-MCSy>*] [sgi-2.4|lgi-2.4] [sgi-5|lgi-5]]",
> NL80211_CMD_SET_TID_CONFIG, 0, CIB_NETDEV, handle_tid_config,
> "Setup per-node TID specific configuration for TIDs selected by bitmask.\n"
> "If MAC address is not specified, then supplied TID configuration\n"
> @@ -955,4 +985,6 @@ COMMAND(set, tidconf, "[peer <MAC address>] tids <mask> [override] [sretry <num>
> " $ iw dev wlan0 tids 0x5 ampdu off amsdu off rtscts on\n"
> " $ iw dev wlan0 tids 0x3 override ampdu on noack on rtscts on\n"
> " $ iw dev wlan0 peer xx:xx:xx:xx:xx:xx tids 0x1 ampdu off tids 0x3 amsdu off rtscts on\n"
> + " $ iw dev wlan0 peer xx:xx:xx:xx:xx:xx tids 0x2 bitrates auto\n"
> + " $ iw dev wlan0 peer xx:xx:xx:xx:xx:xx tids 0x2 bitrates limit vht-mcs-5 4:9\n"
It just occured to me that I wrote incorrect help message in the patch
adding tidconf command. IIRC the correct usage should be:
$ iw dev wlan0 set tidconf peer 1:2:3:4:5:6 tids 0x3 ampdu off tids 0x2 sretry 10 lretry 100
$ iw dev wlan0 set tidconf tids 0xff ampdu off amsdu off sretry 10 lretry 100 noack off
Could you please update new help entries and fix the existing ones ?
Regards,
Sergey
next prev parent reply other threads:[~2020-08-20 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 6:11 [PATCH] iw: add TID specific Tx bitrate configuration Tamizh Chelvam
2020-08-20 7:49 ` Sergey Matyukevich [this message]
2020-08-20 10:02 ` Tamizh Chelvam
2020-08-27 11:37 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820074926.GA2255@curiosity \
--to=geomatsi@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tamizhr@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).