From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 971C0C433DF for ; Thu, 27 Aug 2020 06:33:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68A61207BC for ; Thu, 27 Aug 2020 06:33:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RXk5shD/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727080AbgH0Gdp (ORCPT ); Thu, 27 Aug 2020 02:33:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbgH0Gdo (ORCPT ); Thu, 27 Aug 2020 02:33:44 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1470BC061263 for ; Wed, 26 Aug 2020 23:33:44 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id f7so4205246wrw.1 for ; Wed, 26 Aug 2020 23:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=JTST4BWR1o6f31+3txuRC8iq9BPG0VV2EIdBaLzgefU=; b=RXk5shD/gE6LWb2PuZ+hYpDl4vVfYrjX8ykPsZZyOEn+Xmowin2zLD84PWYt1m/EjK no31UUC6MZgLLQElkysGxiymXszbBPC8NWM4/tqrkDnXR/Pq/ISynXWPMTKbY7Norhrv 2du3wYDqAy+NXulT9StnxMGkTfLgwyWXOrFjOK8iOb+3+ELqZSAuEUcgeteu//tKK68W wH8FQUpLDb8vl4jjlCW8no26QjF3VmHBetRAs1+3jh3EMs7giesKNbi7fgTqO/8ZpKc2 4dSpU/5JanuqNSsED08RZ4GE3HQyBe+sO8iGIbm7nR+S1ck+bLoFzD7V1MPx3HK2Dt8g mj7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=JTST4BWR1o6f31+3txuRC8iq9BPG0VV2EIdBaLzgefU=; b=AkaCyrQnWH9IDe76Sja7cR9LjeZZbuUU4S05jFVoGfkNf4cVIWsJJuk2I6mEEtTk43 zjQVKwYM0mMsQyHYfJn077SlWZWS8U6o00N7nYJS5IFaS0ZezYwz+WR/KDbsmucWrzqY Dn2NAfquQ3gwe5JtrBVlZeN1tqflpnXW/ODR9aBkNygKnrdBeqenBpT8YJv4+f4HJKAL 5sWFtiKk7AclqB7zJeji2csCCTO8O/EHswi7x9Oc7304Urha2D+ts606l7riehaa/EMv HvgWrx1y15j4R/elwLG0Y9o8SEPmvm9CQYL83ACSHlTbWU+DrD7xRyKq9df9LI5F//nB s7Dg== X-Gm-Message-State: AOAM533DD5CzXMO+AIPpT7RYwH6uyerBKI++gZ02g0hiujJf2eTmrzUT cDBcAw+Iu0mBb6yjDlEksdq1sQ== X-Google-Smtp-Source: ABdhPJyfeAUa/Uy7YxxruSqTDkMS7AYe8d4261w2HGfyJAstCNYwquAKmVn6PZeEkXArpYQDHpz+qQ== X-Received: by 2002:a5d:484d:: with SMTP id n13mr18638402wrs.297.1598510021995; Wed, 26 Aug 2020 23:33:41 -0700 (PDT) Received: from dell ([91.110.221.141]) by smtp.gmail.com with ESMTPSA id f16sm3264112wrw.67.2020.08.26.23.33.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 23:33:41 -0700 (PDT) Date: Thu, 27 Aug 2020 07:33:39 +0100 From: Lee Jones To: Kalle Valo Cc: davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Maya Erez , wil6210@qti.qualcomm.com Subject: Re: [PATCH 25/32] wireless: ath: wil6210: wmi: Fix formatting and demote non-conforming function headers Message-ID: <20200827063339.GO3248864@dell> References: <20200821071644.109970-26-lee.jones@linaro.org> <20200826155523.EB372C43387@smtp.codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200826155523.EB372C43387@smtp.codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 26 Aug 2020, Kalle Valo wrote: > Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/net/wireless/ath/wil6210/wmi.c:52: warning: Incorrect use of kernel-doc format: * Addressing - theory of operations > > drivers/net/wireless/ath/wil6210/wmi.c:70: warning: Incorrect use of kernel-doc format: * @sparrow_fw_mapping provides memory remapping table for sparrow > > drivers/net/wireless/ath/wil6210/wmi.c:80: warning: cannot understand function prototype: 'const struct fw_map sparrow_fw_mapping[] = ' > > drivers/net/wireless/ath/wil6210/wmi.c:107: warning: Cannot understand * @sparrow_d0_mac_rgf_ext - mac_rgf_ext section for Sparrow D0 > > drivers/net/wireless/ath/wil6210/wmi.c:115: warning: Cannot understand * @talyn_fw_mapping provides memory remapping table for Talyn > > drivers/net/wireless/ath/wil6210/wmi.c:158: warning: Cannot understand * @talyn_mb_fw_mapping provides memory remapping table for Talyn-MB > > drivers/net/wireless/ath/wil6210/wmi.c:236: warning: Function parameter or member 'x' not described in 'wmi_addr_remap' > > drivers/net/wireless/ath/wil6210/wmi.c:255: warning: Function parameter or member 'section' not described in 'wil_find_fw_mapping' > > drivers/net/wireless/ath/wil6210/wmi.c:278: warning: Function parameter or member 'wil' not described in 'wmi_buffer_block' > > drivers/net/wireless/ath/wil6210/wmi.c:278: warning: Function parameter or member 'ptr_' not described in 'wmi_buffer_block' > > drivers/net/wireless/ath/wil6210/wmi.c:278: warning: Function parameter or member 'size' not described in 'wmi_buffer_block' > > drivers/net/wireless/ath/wil6210/wmi.c:307: warning: Function parameter or member 'wil' not described in 'wmi_addr' > > drivers/net/wireless/ath/wil6210/wmi.c:307: warning: Function parameter or member 'ptr' not described in 'wmi_addr' > > drivers/net/wireless/ath/wil6210/wmi.c:1589: warning: Function parameter or member 'wil' not described in 'wil_find_cid_ringid_sta' > > drivers/net/wireless/ath/wil6210/wmi.c:1589: warning: Function parameter or member 'vif' not described in 'wil_find_cid_ringid_sta' > > drivers/net/wireless/ath/wil6210/wmi.c:1589: warning: Function parameter or member 'cid' not described in 'wil_find_cid_ringid_sta' > > drivers/net/wireless/ath/wil6210/wmi.c:1589: warning: Function parameter or member 'ringid' not described in 'wil_find_cid_ringid_sta' > > drivers/net/wireless/ath/wil6210/wmi.c:1876: warning: Function parameter or member 'vif' not described in 'wmi_evt_ignore' > > drivers/net/wireless/ath/wil6210/wmi.c:1876: warning: Function parameter or member 'id' not described in 'wmi_evt_ignore' > > drivers/net/wireless/ath/wil6210/wmi.c:1876: warning: Function parameter or member 'd' not described in 'wmi_evt_ignore' > > drivers/net/wireless/ath/wil6210/wmi.c:1876: warning: Function parameter or member 'len' not described in 'wmi_evt_ignore' > > drivers/net/wireless/ath/wil6210/wmi.c:2588: warning: Function parameter or member 'wil' not described in 'wmi_rxon' > > > > Cc: Maya Erez > > Cc: Kalle Valo > > Cc: "David S. Miller" > > Cc: Jakub Kicinski > > Cc: linux-wireless@vger.kernel.org > > Cc: wil6210@qti.qualcomm.com > > Cc: netdev@vger.kernel.org > > Signed-off-by: Lee Jones > > So what's the plan, should I drop the six patches for wil6210 in this patchset? I'll fix them and submit the v2s in reply-to the v1s. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog