From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12986C433E1 for ; Thu, 27 Aug 2020 15:20:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E04A62087D for ; Thu, 27 Aug 2020 15:20:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="ewHBYmW/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728469AbgH0PTj (ORCPT ); Thu, 27 Aug 2020 11:19:39 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:50000 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727030AbgH0LdZ (ORCPT ); Thu, 27 Aug 2020 07:33:25 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1598528005; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=7LDSBdIs9MxK1D0YmJUtozSeAA1LtdaBUbnzb467+QY=; b=ewHBYmW/Gwqro1sJZYW/YjQBkNK8JHUJzoK/62ZLQwT0ABa2xAR4c5oVp+JEcvHfg21WKDwy nHyDFdS2DIu3Yc8g/Q2CQBq/vQiPUr65a96jDsKp4K/5bSl4RRMGSOZll/O8MCZRucf3Fk4q WElUJzfyhtx+GDrpuqOKF+YrcAQ= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 5f4799e515988fabe03b0f39 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 27 Aug 2020 11:32:53 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9794EC433A0; Thu, 27 Aug 2020 11:32:53 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 52A9AC433C6; Thu, 27 Aug 2020 11:32:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 52A9AC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH][next] ath11k: fix error check on return from call to ath11k_core_firmware_request From: Kalle Valo In-Reply-To: <20200819105712.51886-1-colin.king@canonical.com> References: <20200819105712.51886-1-colin.king@canonical.com> To: Colin King Cc: "David S . Miller" , Jakub Kicinski , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200827113253.9794EC433A0@smtp.codeaurora.org> Date: Thu, 27 Aug 2020 11:32:53 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The call to ath11k_core_firmware_request is returning a pointer that > can be set to an error code, however, this is not being checked. > Instead ret is being incorrecly checked for the error return. Fix the > error checking. > > Addresses-Coverity: ("Logically dead code") > Fixes: 7b57b2ddec21 ("ath11k: create a common function to request all firmware files") > Signed-off-by: Colin Ian King A similar patch has been already applied. error: patch failed: drivers/net/wireless/ath/ath11k/qmi.c:1886 error: drivers/net/wireless/ath/ath11k/qmi.c: patch does not apply stg import: Diff does not apply cleanly Patch set to Rejected. -- https://patchwork.kernel.org/patch/11723519/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches