Re: [PATCH] ath11k: Allow debugfs to work with 2+ radios installed.

akolli
2020-09-04T16:49:16Z

On 2020-09-04 21:04, Ben Greear wrote:
> On 9/4/20 8:00 AM, akolli@codeaurora.org wrote:
>> On 2020-09-03 22:53, greearb@candelatech.com wrote:
>>> From: Ben Greear <greearb@candelatech.com>
>>>
>>> The code is trying to create an ath11k directory on debugfs
>>> root, but that fails when there is a second radio (and thus
>>> second instance of the driver).
>>>
>>
>> Hi Ben,
>>
>> IPQ8074 is soc and it does not need second debugfs entry, its on AHB.
>> QCA6390 is a pci card and multiple debug entries are needed if
>> multiple cards are available,
>> I am planning to post a patch with bus specific abstraction function
>> which creates single debugfs for soc based radios and multiple entries
>> for PCI based radios.
>>
>> AHB:
>> debugfs/ath11k/IPQ8074/
>>
>> PCI
>> debugfs/ath11k/QCA6390_0001:01:00.0/
>> debugfs/ath11k/QCA6390_0000:01:00.0/
>
> I appreciate your feedback on this!
>
> Why not just stick with the way ath10k does, having the ath11k debugfs
> entry be
> under the phy debugfs directory?
>
> Maybe there is a high-level design document for the ath11k driver
> somewhere that
> explains how and why it is architected with the ath11k base object
> holding multiple
> phy objects?
>

The initial ath11k driver was supporting IPQ8074, its an SOC and has
3-radios under wifi0,
- few entries in debugfs are common for SOC,all these are under
debugfs/ath11k/IPQ8074/
"simulate_fw_crash"
"soc_dp_stats"
- few entries are per radio, these are under
debugfs/ath11k/IPQ8074/mac0/
"ext_tx_stats"
"ext_rx_stats"
"pktlog_filter"
debugfs/ath11k/IPQ8074/mac1
"ext_tx_stats"
"ext_rx_stats"
"pktlog_filter"
debugfs/ath11k/IPQ8074/mac2
"ext_tx_stats"
"ext_rx_stats"
"pktlog_filter"

> And, very curious to know if you are able to get multiple QCA6390 NICs
> running on the
> same system, I'm seeing all sort of problems including NICs not always
> showing up in lspci
> and such.
>
I am not aware of this, like to understand the output of, qrtr-lookup
cmd

Thanks
Anil