From: Lee Jones <lee.jones@linaro.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, linux-wireless@vger.kernel.org
Subject: Re: [wireless-drivers-next:pending 90/109] drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:1027:20: warning: variable 'scb_ampdu' set but not used
Date: Wed, 9 Sep 2020 15:08:59 +0100 [thread overview]
Message-ID: <20200909140859.GC218742@dell> (raw)
In-Reply-To: <87ft8166sj.fsf@codeaurora.org>
On Tue, 01 Sep 2020, Kalle Valo wrote:
> kernel test robot <lkp@intel.com> writes:
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git pending
> > head: 391ddee90739538e99cb73bd26d7a90452d37f30
> > commit: d7f95d9204ca1a73183fde8c5a017f2060763d05 [90/109] brcmsmac: ampdu: Remove a bunch of unused variables
> > config: i386-randconfig-r015-20200901 (attached as .config)
> > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> > reproduce (this is a W=1 build):
> > git checkout d7f95d9204ca1a73183fde8c5a017f2060763d05
> > # save the attached .config to linux build tree
> > make W=1 ARCH=i386
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > In file included from drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.h:21,
> > from drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:18:
> > drivers/net/wireless/broadcom/brcm80211/brcmsmac/d11.h:786:1: warning: alignment 1 of 'struct d11txh' is less than 2 [-Wpacked-not-aligned]
> > 786 | } __packed;
> > | ^
> > drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c: In
> > function 'brcms_c_ampdu_dotxstatus_complete':
> > drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:850:7:
> > warning: variable 'update_rate' set but not used
> > [-Wunused-but-set-variable]
> > 850 | bool update_rate = true, retry = true;
> > | ^~~~~~~~~~~
> > drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c: In function 'brcms_c_ampdu_dotxstatus':
> >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:1027:20: warning: variable 'scb_ampdu' set but not used [-Wunused-but-set-variable]
> > 1027 | struct scb_ampdu *scb_ampdu;
> > | ^~~~~~~~~
>
> Lee, please send a followup patch to fix these issues.
This is already fixed in your tree.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-09-09 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 11:54 [wireless-drivers-next:pending 90/109] drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:1027:20: warning: variable 'scb_ampdu' set but not used kernel test robot
2020-09-01 12:05 ` Kalle Valo
2020-09-08 8:38 ` Lee Jones
2020-09-09 14:08 ` Lee Jones [this message]
2020-09-09 15:09 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909140859.GC218742@dell \
--to=lee.jones@linaro.org \
--cc=kbuild-all@lists.01.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).