From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4020C43463 for ; Mon, 21 Sep 2020 13:11:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 933772145D for ; Mon, 21 Sep 2020 13:11:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="vMai1F8M" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727461AbgIUNLf (ORCPT ); Mon, 21 Sep 2020 09:11:35 -0400 Received: from m42-4.mailgun.net ([69.72.42.4]:44531 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726445AbgIUNLb (ORCPT ); Mon, 21 Sep 2020 09:11:31 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1600693890; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=dvQ8g8G8ZMC0OoVSWlQmLxd3GM1eXbe/mOTaf9do3QU=; b=vMai1F8MWfTI+eUoA6yct2kH15aXxdYcIjzXRAq5+daSaN0VPGD2tHSPiEPB0qj2syYPBLlz zCxt1wVDukfeFTHJrpY+Se5xH5DjhPcL/kogaeSCTp8pZ/azozj2JvJETVe5SxMF0Tno+052 S4L6pGq7dyopGDbO27QIhOJ3IHc= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 5f68a4650915d303570f5e3b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 21 Sep 2020 13:02:29 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7C1E1C433CB; Mon, 21 Sep 2020 13:02:28 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5804BC433F1; Mon, 21 Sep 2020 13:02:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5804BC433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH net] net: wilc1000: clean up resource in error path of init mon interface From: Kalle Valo In-Reply-To: <20200917123019.206382-1-huangguobin4@huawei.com> References: <20200917123019.206382-1-huangguobin4@huawei.com> To: Huang Guobin Cc: , , , , , , , User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200921130228.7C1E1C433CB@smtp.codeaurora.org> Date: Mon, 21 Sep 2020 13:02:28 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Huang Guobin wrote: > The wilc_wfi_init_mon_int() forgets to clean up resource when > register_netdevice() failed. Add the missed call to fix it. > And the return value of netdev_priv can't be NULL, so remove > the unnecessary error handling. > > Fixes: 588713006ea4 ("staging: wilc1000: avoid the use of 'wilc_wfi_mon' static variable") > Reported-by: Hulk Robot > Signed-off-by: Huang Guobin Patch applied to wireless-drivers-next.git, thanks. 55bd14997867 net: wilc1000: clean up resource in error path of init mon interface -- https://patchwork.kernel.org/patch/11782369/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches