Re: [PATCH] mac80211: fix regression in sta connection monitor

Georgi Valkov
2020-10-01T13:59:44Z

Hi Felix!

I can confirm that the original regression is now fully resolved in v3 of your patch.
Further testing showed that the second issue: group key handshake failed (RSN) after 4 tries is unrelated. Apparently OpenWRT does not support group rekeying when WDS is used, so it always fails and should be disabled: option wpa_group_rekey ‘0’.

Please excuse me for taking your time with the unrelated issue. There was no way for me to know that, since the disconnect remained, and it may take up to 24 hours to detect.

Thank you for your help!
Georgi

> On 2020-09-22, at 11:56 AM, Felix Fietkau <nbd@nbd.name> wrote:
>
> On 2020-09-22 09:28, Georgi Valkov wrote:
>> Hi Felix!
>>
>> In the original code before the regression, as well as in the fix I
>> proposed, probe_send_count was always reset if ack is true, while in
>> your fix it will not be reset when non-null frames are received. The
>> connection failed again after 10 hours and the STA remained offline for
>> two minutes instead of two seconds. I should also note that I spent
>> multiple days testing the fix I proposed and I had no disconnects.
>> Please revise your fix again!
> Thanks for the info. Handling non-null frames in that function is
> incomplete, because it does not cover the 802.3 tx status path.
> I'll make v2 patch that checks the timestamp of the last ACK in
> ieee80211_sta_work instead.
>
> - Felix
>