* [bug report] rtw88: add dump firmware fifo support
@ 2020-10-13 14:23 Dan Carpenter
2020-10-14 2:24 ` Andy Huang
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-10-13 14:23 UTC (permalink / raw)
To: tehuang; +Cc: linux-wireless
Hello Tzu-En Huang,
The patch 0fbc2f0f34cc: "rtw88: add dump firmware fifo support" from
Sep 25, 2020, leads to the following static checker warning:
drivers/net/wireless/realtek/rtw88/fw.c:1485 rtw_fw_dump_fifo()
warn: this array is probably non-NULL. 'rtwdev->chip->fw_fifo_addr'
drivers/net/wireless/realtek/rtw88/fw.c
1482 int rtw_fw_dump_fifo(struct rtw_dev *rtwdev, u8 fifo_sel, u32 addr, u32 size,
1483 u32 *buffer)
1484 {
1485 if (!rtwdev->chip->fw_fifo_addr) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Delete this check?
1486 rtw_dbg(rtwdev, RTW_DBG_FW, "chip not support dump fw fifo\n");
1487 return -ENOTSUPP;
1488 }
1489
1490 if (size == 0 || !buffer)
1491 return -EINVAL;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread* RE: [bug report] rtw88: add dump firmware fifo support
2020-10-13 14:23 [bug report] rtw88: add dump firmware fifo support Dan Carpenter
@ 2020-10-14 2:24 ` Andy Huang
0 siblings, 0 replies; 2+ messages in thread
From: Andy Huang @ 2020-10-14 2:24 UTC (permalink / raw)
To: 'Dan Carpenter'; +Cc: linux-wireless@vger.kernel.org
> Hello Tzu-En Huang,
>
> The patch 0fbc2f0f34cc: "rtw88: add dump firmware fifo support" from Sep 25,
> 2020, leads to the following static checker warning:
>
> drivers/net/wireless/realtek/rtw88/fw.c:1485 rtw_fw_dump_fifo()
> warn: this array is probably non-NULL. 'rtwdev->chip->fw_fifo_addr'
>
> drivers/net/wireless/realtek/rtw88/fw.c
> 1482 int rtw_fw_dump_fifo(struct rtw_dev *rtwdev, u8 fifo_sel, u32 addr,
> u32 size,
> 1483 u32 *buffer)
> 1484 {
> 1485 if (!rtwdev->chip->fw_fifo_addr) {
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Delete this check?
>
> 1486 rtw_dbg(rtwdev, RTW_DBG_FW, "chip not
> support dump fw fifo\n");
> 1487 return -ENOTSUPP;
> 1488 }
> 1489
> 1490 if (size == 0 || !buffer)
> 1491 return -EINVAL;
>
> regards,
> dan carpenter
Thanks for the report, and I saw Tom had sent a patch to fix it. I acked on the patch.
Tzu-En
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-14 2:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-13 14:23 [bug report] rtw88: add dump firmware fifo support Dan Carpenter
2020-10-14 2:24 ` Andy Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).