* [PATCH] mt76: mt7603: add additional EEPROM chip ID
@ 2020-10-13 14:23 David Bauer
2020-10-13 14:32 ` Lorenzo Bianconi
0 siblings, 1 reply; 5+ messages in thread
From: David Bauer @ 2020-10-13 14:23 UTC (permalink / raw)
To: nbd, lorenzo.bianconi83, ryder.lee, kvalo, linux-wireless; +Cc: dev, Ron Asimi
Some newer MT7628 based routers (notably the TP-Link Archer C50 v4) are
shipped with a chip-id of 0x7600 in the on-flash EEPROM. Add this as a
possible valid ID.
Ref: https://bugs.openwrt.org/index.php?do=details&task_id=2781
Suggested-by: Ron Asimi <ron.asimi@gmail.com>
Signed-off-by: David Bauer <mail@david-bauer.net>
---
drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c b/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
index 3ee06e2577b8..422b9d9e8962 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
@@ -141,6 +141,7 @@ static int mt7603_check_eeprom(struct mt76_dev *dev)
switch (val) {
case 0x7628:
case 0x7603:
+ case 0x7600:
return 0;
default:
return -EINVAL;
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] mt76: mt7603: add additional EEPROM chip ID
2020-10-13 14:23 [PATCH] mt76: mt7603: add additional EEPROM chip ID David Bauer
@ 2020-10-13 14:32 ` Lorenzo Bianconi
2020-10-13 14:42 ` David Bauer
0 siblings, 1 reply; 5+ messages in thread
From: Lorenzo Bianconi @ 2020-10-13 14:32 UTC (permalink / raw)
To: David Bauer
Cc: nbd, lorenzo.bianconi83, ryder.lee, kvalo, linux-wireless, dev,
Ron Asimi
[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]
> Some newer MT7628 based routers (notably the TP-Link Archer C50 v4) are
> shipped with a chip-id of 0x7600 in the on-flash EEPROM. Add this as a
> possible valid ID.
>
> Ref: https://bugs.openwrt.org/index.php?do=details&task_id=2781
>
> Suggested-by: Ron Asimi <ron.asimi@gmail.com>
> Signed-off-by: David Bauer <mail@david-bauer.net>
> ---
> drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c b/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
> index 3ee06e2577b8..422b9d9e8962 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
> @@ -141,6 +141,7 @@ static int mt7603_check_eeprom(struct mt76_dev *dev)
> switch (val) {
> case 0x7628:
> case 0x7603:
> + case 0x7600:
is it a hw bug or does this part-number really exist?
> return 0;
> default:
> return -EINVAL;
> --
> 2.28.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mt76: mt7603: add additional EEPROM chip ID
2020-10-13 14:32 ` Lorenzo Bianconi
@ 2020-10-13 14:42 ` David Bauer
2020-10-13 16:00 ` Andreas Ziegler
0 siblings, 1 reply; 5+ messages in thread
From: David Bauer @ 2020-10-13 14:42 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: nbd, lorenzo.bianconi83, ryder.lee, kvalo, linux-wireless, dev,
Ron Asimi
Hi Lorenzo,
On 10/13/20 4:32 PM, Lorenzo Bianconi wrote:
>> Some newer MT7628 based routers (notably the TP-Link Archer C50 v4) are
>> shipped with a chip-id of 0x7600 in the on-flash EEPROM. Add this as a
>> possible valid ID.
>>
>> Ref: https://bugs.openwrt.org/index.php?do=details&task_id=2781
>>
>> Suggested-by: Ron Asimi <ron.asimi@gmail.com>
>> Signed-off-by: David Bauer <mail@david-bauer.net>
>> ---
>> drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c b/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
>> index 3ee06e2577b8..422b9d9e8962 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
>> +++ b/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
>> @@ -141,6 +141,7 @@ static int mt7603_check_eeprom(struct mt76_dev *dev)
>> switch (val) {
>> case 0x7628:
>> case 0x7603:
>> + case 0x7600:
>
> is it a hw bug or does this part-number really exist?
I assume it's a bug on TP-Links side. However, there's already quite some units with
this chip-id in their EEPROM around.
Best wishes
David
>
>
>> return 0;
>> default:
>> return -EINVAL;
>> --
>> 2.28.0
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mt76: mt7603: add additional EEPROM chip ID
2020-10-13 14:42 ` David Bauer
@ 2020-10-13 16:00 ` Andreas Ziegler
2020-10-13 23:55 ` David Bauer
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Ziegler @ 2020-10-13 16:00 UTC (permalink / raw)
To: David Bauer, Lorenzo Bianconi
Cc: nbd, lorenzo.bianconi83, ryder.lee, kvalo, linux-wireless,
Ron Asimi
Hi,
David Bauer wrote on 13.10.20 16:42:
>>
>> is it a hw bug or does this part-number really exist?
>
> I assume it's a bug on TP-Links side. However, there's already quite some units with
> this chip-id in their EEPROM around.
to my knowledge, all devices of this specific model (Archer C50 v4) have
this chip-id in their EEPROM, not only some.
Regards
Andreas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mt76: mt7603: add additional EEPROM chip ID
2020-10-13 16:00 ` Andreas Ziegler
@ 2020-10-13 23:55 ` David Bauer
0 siblings, 0 replies; 5+ messages in thread
From: David Bauer @ 2020-10-13 23:55 UTC (permalink / raw)
To: Andreas Ziegler
Cc: Lorenzo Bianconi, nbd, lorenzo.bianconi83, ryder.lee, kvalo,
linux-wireless, Ron Asimi
Hi Andreas,
On 10/13/20 6:00 PM, Andreas Ziegler wrote:
> Hi,
>
> David Bauer wrote on 13.10.20 16:42:
>>>
>>> is it a hw bug or does this part-number really exist?
>>
>> I assume it's a bug on TP-Links side. However, there's already quite some units with
>> this chip-id in their EEPROM around.
>
>
> to my knowledge, all devices of this specific model (Archer C50 v4) have
> this chip-id in their EEPROM, not only some.
The unit I've got back when the v4 first surfaced has the correct chip-id in the
2.4GHz EEPROM (0x7628). However, some (if not all) newer units use 0x7600 as the
chip-id for the MT7628 caldata.
Best wishes
David
>
> Regards
>
> Andreas
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-14 9:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-13 14:23 [PATCH] mt76: mt7603: add additional EEPROM chip ID David Bauer
2020-10-13 14:32 ` Lorenzo Bianconi
2020-10-13 14:42 ` David Bauer
2020-10-13 16:00 ` Andreas Ziegler
2020-10-13 23:55 ` David Bauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).