From: Kalle Valo <kvalo@codeaurora.org>
To: Abhishek Kumar <kuabhs@chromium.org>
Cc: ath10k@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, kuabhs@chromium.org
Subject: Re: [PATCH] ath10k: add option for chip-id based BDF selection
Date: Fri, 6 Nov 2020 07:11:07 +0000 (UTC) [thread overview]
Message-ID: <20201106071107.D7CE3C433C6@smtp.codeaurora.org> (raw)
In-Reply-To: <20201020000506.1.Ifbc28707942179f1cefc7491e995814564495270@changeid>
Abhishek Kumar <kuabhs@chromium.org> wrote:
> In some devices difference in chip-id should be enough to pick
> the right BDF. Add another support for chip-id based BDF selection.
> With this new option, ath10k supports 2 fallback options.
>
> The board name with chip-id as option looks as follows
> board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320'
>
> Signed-off-by: Abhishek Kumar <kuabhs@chromium.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Tested-by: Douglas Anderson <dianders@chromium.org>
> Tested-by: Abhishek Kumar <kuabhs@chromium.org>
There were few checkpatch warnings which I fixed:
$ ath10k-check
drivers/net/wireless/ath/ath10k/core.c:1501: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/core.c:1512: line length of 92 exceeds 90 columns
drivers/net/wireless/ath/ath10k/core.c:1521: line length of 92 exceeds 90 columns
The first one was also what Doug commented. I also added Tested-on tags,
thanks for those. The updated patch is in pending branch (soon).
But is this patch ok to take now? I didn't quite get the conclusion of the
discussion.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201020000506.1.Ifbc28707942179f1cefc7491e995814564495270@changeid/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-11-06 7:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 0:51 [PATCH] ath10k: add option for chip-id based BDF selection Abhishek Kumar
2020-10-20 15:35 ` Doug Anderson
2020-10-23 21:13 ` Abhishek Kumar
[not found] ` <CACTWRwtqcMxZKhDR-Q+3CyOw0Ju=iR+ZMg2pVrHEuzbOUebjOg@mail.gmail.com>
[not found] ` <001a01d6aa24$6ceaf390$46c0dab0$@codeaurora.org>
2020-10-26 22:51 ` Doug Anderson
2020-10-27 5:17 ` Rakesh Pillai
2020-10-27 14:56 ` Doug Anderson
2020-10-27 15:11 ` Rakesh Pillai
2020-11-06 7:11 ` Kalle Valo [this message]
2020-11-10 17:19 ` Abhishek Kumar
2020-11-10 17:33 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106071107.D7CE3C433C6@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=kuabhs@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).