* [PATCH] ath10k: fix compilation warning
@ 2020-11-04 16:37 Tamizh chelvam
2020-11-07 7:56 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Tamizh chelvam @ 2020-11-04 16:37 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Tamizh Chelvam
From: Tamizh Chelvam <tamizhr@codeaurora.org>
This change fixes below compilation warning.
smatch warnings:
drivers/net/wireless/ath/ath10k/mac.c:9125 ath10k_mac_op_set_tid_config() error: uninitialized symbol 'ret'.
No functional changes. Compile tested only.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tamizh Chelvam <tamizhr@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/mac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 12edb1b..9f3224d 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -9182,10 +9182,11 @@ static int ath10k_mac_op_set_tid_config(struct ieee80211_hw *hw,
goto exit;
}
+ ret = 0;
+
if (sta)
goto exit;
- ret = 0;
arvif->tids_rst = 0;
data.curr_vif = vif;
data.ar = ar;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath10k: fix compilation warning
2020-11-04 16:37 [PATCH] ath10k: fix compilation warning Tamizh chelvam
@ 2020-11-07 7:56 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-11-07 7:56 UTC (permalink / raw)
To: Tamizh chelvam; +Cc: ath10k, linux-wireless, Tamizh Chelvam
Tamizh chelvam <tamizhr@codeaurora.org> wrote:
> This change fixes below compilation warning.
>
> smatch warnings:
> drivers/net/wireless/ath/ath10k/mac.c:9125 ath10k_mac_op_set_tid_config() error: uninitialized symbol 'ret'.
>
> No functional changes. Compile tested only.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Tamizh Chelvam <tamizhr@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
b91626451178 ath10k: fix compilation warning
--
https://patchwork.kernel.org/project/linux-wireless/patch/1604507837-29361-1-git-send-email-tamizhr@codeaurora.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-07 7:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-04 16:37 [PATCH] ath10k: fix compilation warning Tamizh chelvam
2020-11-07 7:56 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).