[PATCH] ath11k: Remove unnecessary data sync to cpu on monitor buffer

[PATCH] ath11k: Remove unnecessary data sync to cpu on monitor buffer

[Vasanthakumar Thiagarajan]

Monitor ring Rx buffer is not really modified between dma map
and unmap. So remove the unnecssary data sync before dma unmap.
This does not fix any visible issue, found in code review.

Compile tested only.

Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/dp_rx.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 0162532..4455e5af 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -2856,10 +2856,6 @@ static int ath11k_dp_rx_reap_mon_status_ring(struct ath11k_base *ab, int mac_id,
 
 			rxcb = ATH11K_SKB_RXCB(skb);
 
-			dma_sync_single_for_cpu(ab->dev, rxcb->paddr,
-						skb->len + skb_tailroom(skb),
-						DMA_FROM_DEVICE);
-
 			dma_unmap_single(ab->dev, rxcb->paddr,
 					 skb->len + skb_tailroom(skb),
 					 DMA_BIDIRECTIONAL);
-- 
2.7.4

Re: [PATCH] ath11k: Remove unnecessary data sync to cpu on monitor buffer

[Kalle Valo]

Vasanthakumar Thiagarajan <vthiagar@codeaurora.org> wrote:

> Monitor ring Rx buffer is not really modified between dma map
> and unmap. So remove the unnecssary data sync before dma unmap.
> This does not fix any visible issue, found in code review.
> 
> Compile tested only.
> 
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

bafdbd79aae4 ath11k: Remove unnecessary data sync to cpu on monitor buffer

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1602744454-22969-1-git-send-email-vthiagar@codeaurora.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches