From: Kalle Valo <kvalo@codeaurora.org>
To: Sven Eckelmann <sven@narfation.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Sven Eckelmann <sven@narfation.org>
Subject: Re: [PATCH] ath11k: Fix number of rules in filtered ETSI regdomain
Date: Sat, 7 Nov 2020 08:03:55 +0000 (UTC) [thread overview]
Message-ID: <20201107080355.83BE0C433C9@smtp.codeaurora.org> (raw)
In-Reply-To: <20201030101940.2387952-1-sven@narfation.org>
Sven Eckelmann <sven@narfation.org> wrote:
> The ath11k code will try to insert wheather rader related limits when the
> DFS region is set to ETSI. For this reason, it will add two more entries in
> the array of reg_rules. But the 2.4.0.1 firmware is prefiltering the list
> of reg rules it returns for 2.4GHz PHYs. They will then not contain the
> list of 5GHz rules and thus no wheather radar band rules were inserted by
> this code.
>
> But the code didn't fix the n_reg_rules for this regulatory domain and PHY
> when this happened. This resulted in a rejection by is_valid_rd because it
> found rules which start and end at 0khz. This resulted in a splat like:
>
> Invalid regulatory domain detected
> ------------[ cut here ]------------
> WARNING: at backports-20200628-4.4.60-9a94b73e75/net/wireless/reg.c:3721
> [...]
> ath11k c000000.wifi1: failed to perform regd update : -22
>
> The number of rules must therefore be saved after they were converted from
> the ath11k format to the ieee80211_regdomain format and not before.
>
> Tested with IPQ8074 WLAN.HK.2.4.0.1.r1-00019-QCAHKSWPL_SILICONZ-1
>
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
6189be7d145c ath11k: Fix number of rules in filtered ETSI regdomain
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201030101940.2387952-1-sven@narfation.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-11-07 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 10:19 [PATCH] ath11k: Fix number of rules in filtered ETSI regdomain Sven Eckelmann
2020-11-07 8:03 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201107080355.83BE0C433C9@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).