From: Kalle Valo <kvalo@codeaurora.org>
To: <tehuang@realtek.com>
Cc: <tony0620emma@gmail.com>, <linux-wireless@vger.kernel.org>,
<briannorris@chromium.org>
Subject: Re: [PATCH v2 1/4] rtw88: sync the power state between driver and firmware
Date: Sat, 7 Nov 2020 15:51:35 +0000 (UTC) [thread overview]
Message-ID: <20201107155135.129BCC433C6@smtp.codeaurora.org> (raw)
In-Reply-To: <20201030084826.9034-2-tehuang@realtek.com>
<tehuang@realtek.com> wrote:
> From: Chin-Yen Lee <timlee@realtek.com>
>
> In current flow, driver issues power requests to firmware for entering or
> leaving deep power mode. But driver does not wait for an ack from firmware
> via reading CPWM register when driver requests to enter deep power mode.
> The behavior will lead to unsynchronized state between firmware and driver.
> Furthermore, consecutive same power requests may confuse firmware and leads
> to unexpected value of CPWM register. This patch ensures that the power
> request will wait for an ack from firmware and only send one power request
> each time.
>
> Signed-off-by: Chin-Yen Lee <timlee@realtek.com>
> Signed-off-by: Tzu-En Huang <tehuang@realtek.com>
4 patches applied to wireless-drivers-next.git, thanks.
690390d841d2 rtw88: sync the power state between driver and firmware
a95949606828 rtw88: store firmware feature in firmware header
f31e039fab38 rtw88: add C2H response for checking firmware leave lps
fc3ac64a3a28 rtw88: decide lps deep mode from firmware feature.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201030084826.9034-2-tehuang@realtek.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-11-07 15:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 8:48 [PATCH v2 0/4] rtw88: Update Some Power Saving Feature For the New FW tehuang
2020-10-30 8:48 ` [PATCH v2 1/4] rtw88: sync the power state between driver and firmware tehuang
2020-11-07 15:51 ` Kalle Valo [this message]
2020-10-30 8:48 ` [PATCH v2 2/4] rtw88: store firmware feature in firmware header tehuang
2020-10-30 8:48 ` [PATCH v2 3/4] rtw88: add C2H response for checking firmware leave lps tehuang
2020-10-30 8:48 ` [PATCH v2 4/4] rtw88: decide lps deep mode from firmware feature tehuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201107155135.129BCC433C6@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tehuang@realtek.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).