From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23519C388F9 for ; Mon, 23 Nov 2020 22:41:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6F5220715 for ; Mon, 23 Nov 2020 22:41:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732823AbgKWWl1 (ORCPT ); Mon, 23 Nov 2020 17:41:27 -0500 Received: from mga02.intel.com ([134.134.136.20]:22248 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728873AbgKWWl1 (ORCPT ); Mon, 23 Nov 2020 17:41:27 -0500 IronPort-SDR: hlGelISRsegCfFd0Ri2+XukP0iEQZvIXL1+Vn8hEZl1MRwlcHCR1Dl0yyMTg5JO9gw+jXkwTp1 Tsn3iBJagMrw== X-IronPort-AV: E=McAfee;i="6000,8403,9814"; a="158898208" X-IronPort-AV: E=Sophos;i="5.78,364,1599548400"; d="scan'208";a="158898208" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 14:41:26 -0800 IronPort-SDR: vJN4A4DJJkI7jqvaF7H4MZk0eG1r8QwQpXlltnDw211z84znh8bVsZQkp3IzgAbCMqcQJV1foJ KXNYdsw6UeYw== X-IronPort-AV: E=Sophos;i="5.78,364,1599548400"; d="scan'208";a="546586401" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.209.57.186]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 14:41:26 -0800 Date: Mon, 23 Nov 2020 14:41:26 -0800 From: Jesse Brandeburg To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch, mkubecek@suse.cz, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, Johannes Berg Subject: Re: [PATCH net-next v2] net: don't include ethtool.h from netdevice.h Message-ID: <20201123144126.00003133@intel.com> In-Reply-To: <20201120225052.1427503-1-kuba@kernel.org> References: <20201120225052.1427503-1-kuba@kernel.org> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jakub Kicinski wrote: > linux/netdevice.h is included in very many places, touching any > of its dependecies causes large incremental builds. > > Drop the linux/ethtool.h include, linux/netdevice.h just needs > a forward declaration of struct ethtool_ops. > > Fix all the places which made use of this implicit include. > > Acked-by: Johannes Berg > Signed-off-by: Jakub Kicinski Reviewed-by: Jesse Brandeburg