* [PATCH] net: cisco: remove trailing semicolon in macro definition
@ 2020-11-27 17:58 trix
2020-11-27 23:04 ` Kieran Bingham
2020-12-02 19:39 ` airo: " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: trix @ 2020-11-27 17:58 UTC (permalink / raw)
To: kvalo, davem, kuba, bigeasy, mpe, lee.jones,
kieran.bingham+renesas, dan.carpenter, adobriyan
Cc: linux-wireless, netdev, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
The macro use will already have a semicolon.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/wireless/cisco/airo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/cisco/airo.c b/drivers/net/wireless/cisco/airo.c
index 74acf9af2adb..ba62bb2995d9 100644
--- a/drivers/net/wireless/cisco/airo.c
+++ b/drivers/net/wireless/cisco/airo.c
@@ -5785,7 +5785,7 @@ static int airo_get_quality (StatusRid *status_rid, CapabilityRid *cap_rid)
}
#define airo_get_max_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x20 : 0xa0)
-#define airo_get_avg_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x10 : 0x50);
+#define airo_get_avg_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x10 : 0x50)
/*------------------------------------------------------------------*/
/*
--
2.18.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: cisco: remove trailing semicolon in macro definition
2020-11-27 17:58 [PATCH] net: cisco: remove trailing semicolon in macro definition trix
@ 2020-11-27 23:04 ` Kieran Bingham
2020-12-02 19:39 ` airo: " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2020-11-27 23:04 UTC (permalink / raw)
To: trix, kvalo, davem, kuba, bigeasy, mpe, lee.jones, dan.carpenter,
adobriyan
Cc: linux-wireless, netdev, linux-kernel
Hi Tom,
On 27/11/2020 17:58, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Seems to be the only occurrence in this file.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/net/wireless/cisco/airo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/cisco/airo.c b/drivers/net/wireless/cisco/airo.c
> index 74acf9af2adb..ba62bb2995d9 100644
> --- a/drivers/net/wireless/cisco/airo.c
> +++ b/drivers/net/wireless/cisco/airo.c
> @@ -5785,7 +5785,7 @@ static int airo_get_quality (StatusRid *status_rid, CapabilityRid *cap_rid)
> }
>
> #define airo_get_max_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x20 : 0xa0)
> -#define airo_get_avg_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x10 : 0x50);
> +#define airo_get_avg_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x10 : 0x50)
>
> /*------------------------------------------------------------------*/
> /*
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: airo: remove trailing semicolon in macro definition
2020-11-27 17:58 [PATCH] net: cisco: remove trailing semicolon in macro definition trix
2020-11-27 23:04 ` Kieran Bingham
@ 2020-12-02 19:39 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-12-02 19:39 UTC (permalink / raw)
To: trix
Cc: davem, kuba, bigeasy, mpe, lee.jones, kieran.bingham+renesas,
dan.carpenter, adobriyan, linux-wireless, netdev, linux-kernel,
Tom Rix
trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Patch applied to wireless-drivers-next.git, thanks.
a460b0e1bab8 airo: remove trailing semicolon in macro definition
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201127175821.2756988-1-trix@redhat.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-02 19:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-27 17:58 [PATCH] net: cisco: remove trailing semicolon in macro definition trix
2020-11-27 23:04 ` Kieran Bingham
2020-12-02 19:39 ` airo: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).