From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Yan-Hsuan Chuang <tony0620emma@gmail.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Brian Norris <briannorris@chromium.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] rtw88: debug: Fix uninitialized memory in debugfs code
Date: Thu, 3 Dec 2020 14:33:37 +0300 [thread overview]
Message-ID: <20201203113337.GL2789@kadam> (raw)
In-Reply-To: <87pn3rgsgi.fsf@codeaurora.org>
On Thu, Dec 03, 2020 at 11:16:29AM +0200, Kalle Valo wrote:
> Dan Carpenter <dan.carpenter@oracle.com> writes:
>
> > This code does not ensure that the whole buffer is initialized and none
> > of the callers check for errors so potentially none of the buffer is
> > initialized. Add a memset to eliminate this bug.
> >
> > Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > drivers/net/wireless/realtek/rtw88/debug.c | 2 ++
> > 1 file changed, 2 insertions(+)
>
> I'll take this to wireless-drivers, this shouldn't go to net.
Ugh... The worst part about that is that I manually added the "net"
part without thinking thouroughly. :/ Anyway, I've modified my QC
scripts now.
regards,
dan carpenter
next prev parent reply other threads:[~2020-12-03 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 8:43 [PATCH net] rtw88: debug: Fix uninitialized memory in debugfs code Dan Carpenter
2020-12-03 9:16 ` Kalle Valo
2020-12-03 11:33 ` Dan Carpenter [this message]
2020-12-03 16:01 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203113337.GL2789@kadam \
--to=dan.carpenter@oracle.com \
--cc=briannorris@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).