From: Kalle Valo <kvalo@codeaurora.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: <tony0620emma@gmail.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] rtw88: fix multiple definition of rtw_pm_ops
Date: Tue, 8 Dec 2020 07:34:51 +0000 (UTC) [thread overview]
Message-ID: <20201208073451.0D0A3C433CA@smtp.codeaurora.org> (raw)
In-Reply-To: <20201208013746.11065-1-pkshih@realtek.com>
Ping-Ke Shih <pkshih@realtek.com> wrote:
> 'const struct dev_pm_ops rtw_pm_ops' is declared by pci.c, and it should be
> declare as 'extern' in pci.h. Without 'extern' causes every file including
> pci.h has an individual instance of rtw_pm_ops but not reference to the one
> declared in pci.c
>
> If kernel config, like test robot, doesn't build driver as module, it leads
> multiple definition.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 2e86ef413ab3 ("rtw88: pci: Add prototypes for .probe, .remove and .shutdown")
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
91aeaf09a6ee rtw88: fix multiple definition of rtw_pm_ops
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201208013746.11065-1-pkshih@realtek.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-12-08 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 1:37 [PATCH] rtw88: fix multiple definition of rtw_pm_ops Ping-Ke Shih
2020-12-08 7:34 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208073451.0D0A3C433CA@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).