Re: [PATCH] rtlwifi: rise completion at the last step of firmware callback

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3654 bytes --]

Hi Ping-Ke,

I love your patch! Yet something to improve:

[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on wireless-drivers/master v5.10 next-20201211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ping-Ke-Shih/rtlwifi-rise-completion-at-the-last-step-of-firmware-callback/20201214-095732
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: m68k-randconfig-r035-20201214 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/d6328e8677e1f940022051a1cb58c2b36731a571
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ping-Ke-Shih/rtlwifi-rise-completion-at-the-last-step-of-firmware-callback/20201214-095732
        git checkout d6328e8677e1f940022051a1cb58c2b36731a571
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/wireless/realtek/rtlwifi/core.c: In function 'rtl_fw_do_work':
>> drivers/net/wireless/realtek/rtlwifi/core.c:112:1: error: 'exit' undeclared (first use in this function)
     112 | exit;
         | ^~~~
   drivers/net/wireless/realtek/rtlwifi/core.c:112:1: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net/wireless/realtek/rtlwifi/core.c:99:3: error: label 'exit' used but not defined
      99 |   goto exit;
         |   ^~~~

vim +/exit +112 drivers/net/wireless/realtek/rtlwifi/core.c

    71	
    72	static void rtl_fw_do_work(const struct firmware *firmware, void *context,
    73				   bool is_wow)
    74	{
    75		struct ieee80211_hw *hw = context;
    76		struct rtl_priv *rtlpriv = rtl_priv(hw);
    77		int err;
    78	
    79		rtl_dbg(rtlpriv, COMP_ERR, DBG_LOUD,
    80			"Firmware callback routine entered!\n");
    81		if (!firmware) {
    82			if (rtlpriv->cfg->alt_fw_name) {
    83				err = request_firmware(&firmware,
    84						       rtlpriv->cfg->alt_fw_name,
    85						       rtlpriv->io.dev);
    86				pr_info("Loading alternative firmware %s\n",
    87					rtlpriv->cfg->alt_fw_name);
    88				if (!err)
    89					goto found_alt;
    90			}
    91			pr_err("Selected firmware is not available\n");
    92			rtlpriv->max_fw_size = 0;
    93			goto exit;
    94		}
    95	found_alt:
    96		if (firmware->size > rtlpriv->max_fw_size) {
    97			pr_err("Firmware is too big!\n");
    98			release_firmware(firmware);
  > 99			goto exit;
   100		}
   101		if (!is_wow) {
   102			memcpy(rtlpriv->rtlhal.pfirmware, firmware->data,
   103			       firmware->size);
   104			rtlpriv->rtlhal.fwsize = firmware->size;
   105		} else {
   106			memcpy(rtlpriv->rtlhal.wowlan_firmware, firmware->data,
   107			       firmware->size);
   108			rtlpriv->rtlhal.wowlan_fwsize = firmware->size;
   109		}
   110		release_firmware(firmware);
   111	
 > 112	exit;
   113		complete(&rtlpriv->firmware_loading_complete);
   114	}
   115	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 21074 bytes --]