linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 4/7] wil6210: select CONFIG_CRC32
       [not found] <20210103213645.1994783-1-arnd@kernel.org>
@ 2021-01-03 21:36 ` Arnd Bergmann
  2021-01-11 11:47   ` Kalle Valo
  2021-01-14 18:45   ` Kalle Valo
  2021-01-03 21:36 ` [PATCH 5/7] cfg80211: " Arnd Bergmann
  1 sibling, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-01-03 21:36 UTC (permalink / raw)
  To: Maya Erez, Kalle Valo, David S. Miller, Jakub Kicinski
  Cc: Arnd Bergmann, John W. Linville, Vladimir Kondratiev,
	linux-wireless, wil6210, netdev, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Without crc32, the driver fails to link:

arm-linux-gnueabi-ld: drivers/net/wireless/ath/wil6210/fw.o: in function `wil_fw_verify':
fw.c:(.text+0x74c): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/net/wireless/ath/wil6210/fw.o:fw.c:(.text+0x758): more undefined references to `crc32_le' follow

Fixes: 151a9706503f ("wil6210: firmware download")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/wireless/ath/wil6210/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/wil6210/Kconfig b/drivers/net/wireless/ath/wil6210/Kconfig
index 6a95b199bf62..f074e9c31aa2 100644
--- a/drivers/net/wireless/ath/wil6210/Kconfig
+++ b/drivers/net/wireless/ath/wil6210/Kconfig
@@ -2,6 +2,7 @@
 config WIL6210
 	tristate "Wilocity 60g WiFi card wil6210 support"
 	select WANT_DEV_COREDUMP
+	select CRC32
 	depends on CFG80211
 	depends on PCI
 	default n
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 5/7] cfg80211: select CONFIG_CRC32
       [not found] <20210103213645.1994783-1-arnd@kernel.org>
  2021-01-03 21:36 ` [PATCH 4/7] wil6210: select CONFIG_CRC32 Arnd Bergmann
@ 2021-01-03 21:36 ` Arnd Bergmann
  1 sibling, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-01-03 21:36 UTC (permalink / raw)
  To: Johannes Berg, David S. Miller, Jakub Kicinski
  Cc: Arnd Bergmann, Tova Mussai, linux-wireless, netdev, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Without crc32 support, this fails to link:

arm-linux-gnueabi-ld: net/wireless/scan.o: in function `cfg80211_scan_6ghz':
scan.c:(.text+0x928): undefined reference to `crc32_le'

Fixes: c8cb5b854b40 ("nl80211/cfg80211: support 6 GHz scanning")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 net/wireless/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
index 27026f587fa6..f620acd2a0f5 100644
--- a/net/wireless/Kconfig
+++ b/net/wireless/Kconfig
@@ -21,6 +21,7 @@ config CFG80211
 	tristate "cfg80211 - wireless configuration API"
 	depends on RFKILL || !RFKILL
 	select FW_LOADER
+	select CRC32
 	# may need to update this when certificates are changed and are
 	# using a different algorithm, though right now they shouldn't
 	# (this is here rather than below to allow it to be a module)
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 4/7] wil6210: select CONFIG_CRC32
  2021-01-03 21:36 ` [PATCH 4/7] wil6210: select CONFIG_CRC32 Arnd Bergmann
@ 2021-01-11 11:47   ` Kalle Valo
  2021-01-14 18:45   ` Kalle Valo
  1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2021-01-11 11:47 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Maya Erez, David S. Miller, Jakub Kicinski, Arnd Bergmann,
	John W. Linville, Vladimir Kondratiev, linux-wireless, wil6210,
	netdev, linux-kernel

Arnd Bergmann <arnd@kernel.org> writes:

> From: Arnd Bergmann <arnd@arndb.de>
>
> Without crc32, the driver fails to link:
>
> arm-linux-gnueabi-ld: drivers/net/wireless/ath/wil6210/fw.o: in function `wil_fw_verify':
> fw.c:(.text+0x74c): undefined reference to `crc32_le'
> arm-linux-gnueabi-ld: drivers/net/wireless/ath/wil6210/fw.o:fw.c:(.text+0x758): more undefined references to `crc32_le' follow
>
> Fixes: 151a9706503f ("wil6210: firmware download")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I'll queue this to v5.11.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 4/7] wil6210: select CONFIG_CRC32
  2021-01-03 21:36 ` [PATCH 4/7] wil6210: select CONFIG_CRC32 Arnd Bergmann
  2021-01-11 11:47   ` Kalle Valo
@ 2021-01-14 18:45   ` Kalle Valo
  1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2021-01-14 18:45 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Maya Erez, David S. Miller, Jakub Kicinski, Arnd Bergmann,
	John W. Linville, Vladimir Kondratiev, linux-wireless, wil6210,
	netdev, linux-kernel

Arnd Bergmann <arnd@kernel.org> wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> Without crc32, the driver fails to link:
> 
> arm-linux-gnueabi-ld: drivers/net/wireless/ath/wil6210/fw.o: in function `wil_fw_verify':
> fw.c:(.text+0x74c): undefined reference to `crc32_le'
> arm-linux-gnueabi-ld: drivers/net/wireless/ath/wil6210/fw.o:fw.c:(.text+0x758): more undefined references to `crc32_le' follow
> 
> Fixes: 151a9706503f ("wil6210: firmware download")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Dave had already applied this so dropping from my queue.

Patch set to Not Applicable.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210103213645.1994783-4-arnd@kernel.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-14 18:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20210103213645.1994783-1-arnd@kernel.org>
2021-01-03 21:36 ` [PATCH 4/7] wil6210: select CONFIG_CRC32 Arnd Bergmann
2021-01-11 11:47   ` Kalle Valo
2021-01-14 18:45   ` Kalle Valo
2021-01-03 21:36 ` [PATCH 5/7] cfg80211: " Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).