* [PATCH] mt7601u: process URBs in status EPROTO properly
@ 2020-12-17 16:13 Zhi Han
2021-01-14 17:30 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Zhi Han @ 2020-12-17 16:13 UTC (permalink / raw)
To: linux-wireless; +Cc: kuba
When the usb device being plugged out, before the usb_driver:disconnect
called by e.g workqueue, it is possible that some URBs are still in
processing, and being marked as EPROTO in host controller.
Those URBs should not be scheduled in complete_rx callback function to
get further processing.
Signed-off-by: Zhi Han <z.han@gmx.net>
Acked-by: Jakub Kicinski <kuba@kernel.org>
---
drivers/net/wireless/mediatek/mt7601u/dma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c
index 09f931d4598c..7a9ab787cf3d 100644
--- a/drivers/net/wireless/mediatek/mt7601u/dma.c
+++ b/drivers/net/wireless/mediatek/mt7601u/dma.c
@@ -192,6 +192,7 @@ static void mt7601u_complete_rx(struct urb *urb)
case -ECONNRESET:
case -ESHUTDOWN:
case -ENOENT:
+ case -EPROTO:
return;
default:
dev_err_ratelimited(dev->dev, "rx urb failed: %d\n",
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mt7601u: process URBs in status EPROTO properly
2020-12-17 16:13 [PATCH] mt7601u: process URBs in status EPROTO properly Zhi Han
@ 2021-01-14 17:30 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-01-14 17:30 UTC (permalink / raw)
To: Zhi Han; +Cc: linux-wireless, kuba
Zhi Han <z.han@gmx.net> wrote:
> When the usb device being plugged out, before the usb_driver:disconnect
> called by e.g workqueue, it is possible that some URBs are still in
> processing, and being marked as EPROTO in host controller.
>
> Those URBs should not be scheduled in complete_rx callback function to
> get further processing.
>
> Signed-off-by: Zhi Han <z.han@gmx.net>
> Acked-by: Jakub Kicinski <kuba@kernel.org>
Patch applied to wireless-drivers-next.git, thanks.
0e40dbd56d67 mt7601u: process URBs in status EPROTO properly
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201217161302.GA12562@E480/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-14 17:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-17 16:13 [PATCH] mt7601u: process URBs in status EPROTO properly Zhi Han
2021-01-14 17:30 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).