From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4186CC433DB for ; Thu, 14 Jan 2021 17:35:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1868423B3E for ; Thu, 14 Jan 2021 17:35:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727512AbhANRfm (ORCPT ); Thu, 14 Jan 2021 12:35:42 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:25404 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbhANRfl (ORCPT ); Thu, 14 Jan 2021 12:35:41 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1610645718; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=9IYNUrVXzLK4CDgiFD5gCW/jwjuQjdTQHEdGD9cetfM=; b=cnRuJ+CfUVV2WvDcVh9HidHfCcARskSZzwhPnOuWJULRudPyjj8TgN5MwkypeuYAA/mwOBUg tLmG37Q5KAgee/L5TSlVS8VDn9jLPdkCPkM3U1wbAcgudDCqXjFd55MLfiSwMc3hOQEuvkB/ u+kbLZgfAyq/JP23gMT3ugy059Y= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 600080b7c88af06107fc8fd8 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 14 Jan 2021 17:34:47 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6942CC43462; Thu, 14 Jan 2021 17:34:46 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 82DF5C433CA; Thu, 14 Jan 2021 17:34:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 82DF5C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wlcore: Fix command execute failure 19 for wl12xx From: Kalle Valo In-Reply-To: <20201231085343.24337-1-tony@atomide.com> References: <20201231085343.24337-1-tony@atomide.com> To: Tony Lindgren Cc: Eyal Reizer , Guy Mishol , Raz Bouganim , linux-wireless@vger.kernel.org, linux-omap@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210114173446.6942CC43462@smtp.codeaurora.org> Date: Thu, 14 Jan 2021 17:34:46 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Tony Lindgren wrote: > We can currently get a "command execute failure 19" error on beacon loss > if the signal is weak: > > wlcore: Beacon loss detected. roles:0xff > wlcore: Connection loss work (role_id: 0). > ... > wlcore: ERROR command execute failure 19 > ... > WARNING: CPU: 0 PID: 1552 at drivers/net/wireless/ti/wlcore/main.c:803 > ... > (wl12xx_queue_recovery_work.part.0 [wlcore]) > (wl12xx_cmd_role_start_sta [wlcore]) > (wl1271_op_bss_info_changed [wlcore]) > (ieee80211_prep_connection [mac80211]) > > Error 19 is defined as CMD_STATUS_WRONG_NESTING from the wlcore firmware, > and seems to mean that the firmware no longer wants to see the quirk > handling for WLCORE_QUIRK_START_STA_FAILS done. > > This quirk got added with commit 18eab430700d ("wlcore: workaround > start_sta problem in wl12xx fw"), and it seems that this already got fixed > in the firmware long time ago back in 2012 as wl18xx never had this quirk > in place to start with. > > As we no longer even support firmware that early, to me it seems that it's > safe to just drop WLCORE_QUIRK_START_STA_FAILS to fix the error. Looks > like earlier firmware got disabled back in 2013 with commit 0e284c074ef9 > ("wl12xx: increase minimum singlerole firmware version required"). > > If it turns out we still need WLCORE_QUIRK_START_STA_FAILS with any > firmware that the driver works with, we can simply revert this patch and > add extra checks for firmware version used. > > With this fix wlcore reconnects properly after a beacon loss. > > Cc: Raz Bouganim > Signed-off-by: Tony Lindgren Failed to apply to wireless-drivers-next: fatal: sha1 information is lacking or useless (drivers/net/wireless/ti/wl12xx/main.c). error: could not build fake ancestor Applying: wlcore: Fix command execute failure 19 for wl12xx Patch failed at 0001 wlcore: Fix command execute failure 19 for wl12xx The copy of the patch that failed is found in: .git/rebase-apply/patch Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20201231085343.24337-1-tony@atomide.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches