From: Lee <leegib@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: Fix possible buffer overflow in _rtl92e_wx_set_scan
Date: Mon, 1 Mar 2021 15:37:42 +0000 [thread overview]
Message-ID: <20210301153742.GA427438@ubuntudesktop> (raw)
In-Reply-To: <20210301132535.GR2087@kadam>
> This check worked out pretty well. It's probably 50% bugs? Unfiltered
> results below. The trick of warning for "if (ststr(member, "->ssid")) "
> and the memcpy length couldn't be verified turned out to be the best.
That list looks great. I checked out 2 of those listed at random and
they look like valid bugs to me.
> But there are quite a few real bugs as well. If anyone wants to fix any
> of these just claim a bug, and I won't send a patch for that warning.
> :) Lee, I think you mentioned that you had found a related buffer
> overflow fix? Did the check find it?
I think I found 2 in these files:
drivers/staging/rtl8712/rtl871x_cmd.c
drivers/staging/wfx/hif_tx.c
Regards,
Lee
next prev parent reply other threads:[~2021-03-01 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210226114829.316980-1-leegib@gmail.com>
[not found] ` <20210226134333.GA2087@kadam>
[not found] ` <20210226140526.GG2222@kadam>
2021-03-01 13:25 ` [PATCH] staging: rtl8192e: Fix possible buffer overflow in _rtl92e_wx_set_scan Dan Carpenter
2021-03-01 15:37 ` Lee [this message]
2021-03-05 8:22 ` Dan Carpenter
2021-03-05 15:00 ` Lee
2021-03-08 7:57 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301153742.GA427438@ubuntudesktop \
--to=leegib@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).