From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Yan-Hsuan Chuang <tony0620emma@gmail.com>,
Tzu-En Huang <tehuang@realtek.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] rtw88: Fix an error code in rtw_debugfs_set_rsvd_page()
Date: Mon, 15 Mar 2021 08:08:17 +0000 (UTC) [thread overview]
Message-ID: <20210315080817.D04F3C43462@smtp.codeaurora.org> (raw)
In-Reply-To: <YCwgb/4F4Y+tyE56@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The sscanf() function returns either 0 or 1 here. It doesn't return
> error codes. We should return -EINVAL if the string is invalid.
>
> Fixes: c376c1fc87b7 ("rtw88: add h2c command in debugfs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Why do you remove the num variable? I think the code is more readable with it.
(Sorry, I'm not able to quote the code as I'm replying from patchwork script
and it doesn't support that yet.)
--
https://patchwork.kernel.org/project/linux-wireless/patch/YCwgb/4F4Y+tyE56@mwanda/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-03-15 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 19:43 [PATCH] rtw88: Fix an error code in rtw_debugfs_set_rsvd_page() Dan Carpenter
2021-03-15 8:08 ` Kalle Valo [this message]
[not found] ` <20210315080817.A3975C43461@smtp.codeaurora.org>
2021-03-15 9:11 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315080817.D04F3C43462@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tehuang@realtek.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).