From: kernel test robot <lkp@intel.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
kvalo@codeaurora.org, wcn36xx@lists.infradead.org,
linux-wireless@vger.kernel.org
Cc: kbuild-all@lists.01.org, bryan.odonoghue@linaro.org,
shawn.guo@linaro.org, benl@squareup.com, loic.poulain@linaro.org,
bjorn.andersson@linaro.org
Subject: Re: [PATCH v2 06/12] wcn36xx: Add ipv6 namespace offload in suspend
Date: Mon, 15 Mar 2021 22:18:56 +0800 [thread overview]
Message-ID: <202103152217.bBCw97Sq-lkp@intel.com> (raw)
In-Reply-To: <20210315120937.2512341-7-bryan.odonoghue@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 4880 bytes --]
Hi Bryan,
I love your patch! Yet something to improve:
[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on wireless-drivers/master ath6kl/ath-next v5.12-rc3 next-20210315]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/wcn36xx-Enable-downstream-consistent-Wake-on-Lan/20210315-201014
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: h8300-randconfig-r032-20210315 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/84a113e3918b369b7f17d291899f9eefbbc60ca9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bryan-O-Donoghue/wcn36xx-Enable-downstream-consistent-Wake-on-Lan/20210315-201014
git checkout 84a113e3918b369b7f17d291899f9eefbbc60ca9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_ipv6_ns_offload':
>> drivers/net/wireless/ath/wcn36xx/smd.c:2815:15: error: 'struct wcn36xx_vif' has no member named 'num_target_ipv6_addrs'
2815 | if (vif_priv->num_target_ipv6_addrs) {
| ^~
>> drivers/net/wireless/ath/wcn36xx/smd.c:2817:20: error: 'struct wcn36xx_vif' has no member named 'target_ipv6_addrs'
2817 | &vif_priv->target_ipv6_addrs[0].in6_u,
| ^~
drivers/net/wireless/ath/wcn36xx/smd.c:2820:20: error: 'struct wcn36xx_vif' has no member named 'target_ipv6_addrs'
2820 | &vif_priv->target_ipv6_addrs[0].in6_u,
| ^~
drivers/net/wireless/ath/wcn36xx/smd.c:2824:15: error: 'struct wcn36xx_vif' has no member named 'num_target_ipv6_addrs'
2824 | if (vif_priv->num_target_ipv6_addrs > 1) {
| ^~
drivers/net/wireless/ath/wcn36xx/smd.c:2826:20: error: 'struct wcn36xx_vif' has no member named 'target_ipv6_addrs'
2826 | &vif_priv->target_ipv6_addrs[1].in6_u,
| ^~
vim +2815 drivers/net/wireless/ath/wcn36xx/smd.c
2795
2796 int wcn36xx_smd_ipv6_ns_offload(struct wcn36xx *wcn, struct ieee80211_vif *vif,
2797 bool enable)
2798 {
2799 struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
2800 struct wcn36xx_hal_host_offload_req_msg msg_body;
2801 struct wcn36xx_hal_ns_offload_params *ns_params;
2802 struct wcn36xx_hal_host_offload_req *ho_params;
2803 int ret;
2804
2805 mutex_lock(&wcn->hal_mutex);
2806
2807 INIT_HAL_MSG(msg_body, WCN36XX_HAL_HOST_OFFLOAD_REQ);
2808 ho_params = &msg_body.host_offload_params;
2809 ns_params = &msg_body.ns_offload_params;
2810
2811 ho_params->offload_type = WCN36XX_HAL_IPV6_NS_OFFLOAD;
2812 if (enable) {
2813 ho_params->enable =
2814 WCN36XX_HAL_OFFLOAD_NS_AND_MCAST_FILTER_ENABLE;
> 2815 if (vif_priv->num_target_ipv6_addrs) {
2816 memcpy(&ho_params->u,
> 2817 &vif_priv->target_ipv6_addrs[0].in6_u,
2818 sizeof(struct in6_addr));
2819 memcpy(&ns_params->target_ipv6_addr1,
2820 &vif_priv->target_ipv6_addrs[0].in6_u,
2821 sizeof(struct in6_addr));
2822 ns_params->target_ipv6_addr1_valid = 1;
2823 }
2824 if (vif_priv->num_target_ipv6_addrs > 1) {
2825 memcpy(&ns_params->target_ipv6_addr2,
2826 &vif_priv->target_ipv6_addrs[1].in6_u,
2827 sizeof(struct in6_addr));
2828 ns_params->target_ipv6_addr2_valid = 1;
2829 }
2830 }
2831 memcpy(&ns_params->self_addr, vif->addr, ETH_ALEN);
2832 ns_params->bss_index = vif_priv->bss_index;
2833
2834 PREPARE_HAL_BUF(wcn->hal_buf, msg_body);
2835
2836 ret = wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);
2837 if (ret) {
2838 wcn36xx_err("Sending host_offload_arp failed\n");
2839 goto out;
2840 }
2841 ret = wcn36xx_smd_rsp_status_check(wcn->hal_buf, wcn->hal_rsp_len);
2842 if (ret) {
2843 wcn36xx_err("host_offload_arp failed err=%d\n", ret);
2844 goto out;
2845 }
2846 out:
2847 mutex_unlock(&wcn->hal_mutex);
2848 return ret;
2849 }
2850
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41206 bytes --]
next prev parent reply other threads:[~2021-03-15 14:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 12:09 [PATCH v2 00/12] wcn36xx: Enable downstream consistent Wake on Lan Bryan O'Donoghue
2021-03-15 12:09 ` [PATCH v2 01/12] wcn36xx: Return result of set_power_params in suspend Bryan O'Donoghue
2021-03-15 12:09 ` [PATCH v2 02/12] wcn36xx: Run suspend for the first ieee80211_vif Bryan O'Donoghue
2021-03-15 12:09 ` [PATCH v2 03/12] wcn36xx: Add ipv4 ARP offload support in suspend Bryan O'Donoghue
2021-03-15 12:09 ` [PATCH v2 04/12] wcn36xx: Do not flush indication queue on suspend/resume Bryan O'Donoghue
2021-03-15 12:09 ` [PATCH v2 05/12] wcn36xx: Add ipv6 address tracking Bryan O'Donoghue
2021-03-15 12:09 ` [PATCH v2 06/12] wcn36xx: Add ipv6 namespace offload in suspend Bryan O'Donoghue
2021-03-15 14:18 ` kernel test robot [this message]
2021-03-15 15:16 ` Bryan O'Donoghue
2021-03-15 12:09 ` [PATCH v2 07/12] wcn36xx: Add set_rekey_data callback Bryan O'Donoghue
2021-03-15 12:09 ` [PATCH v2 08/12] wcn36xx: Add GTK offload to WoWLAN path Bryan O'Donoghue
2021-03-15 12:09 ` [PATCH v2 09/12] wcn36xx: Add GTK offload info to WoWLAN resume Bryan O'Donoghue
2021-03-15 12:09 ` [PATCH v2 10/12] wcn36xx: Add Host suspend indication support Bryan O'Donoghue
2021-03-15 12:09 ` [PATCH v2 11/12] wcn36xx: Add host resume request support Bryan O'Donoghue
2021-03-15 12:09 ` [PATCH v2 12/12] wcn36xx: Enable WOWLAN flags Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103152217.bBCw97Sq-lkp@intel.com \
--to=lkp@intel.com \
--cc=benl@squareup.com \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=kbuild-all@lists.01.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox