Re: [RFC PATCH] mt7601u: make the driver work again

[Stanislaw Gruszka <stf_xl@wp.pl>]

Hi

On Wed, May 05, 2021 at 09:01:52AM +0100, Rui Salvaterra wrote:
> On Wed, 5 May 2021 at 05:50, Stanislaw Gruszka <stf_xl@wp.pl> wrote:
> >
> > I'm not sure if DPD calibration is needed. Maybe is ok to disable it for
> > all MT7601U devices. However safer fix would be doing it only for
> > devices that know to need it for work. For example: add dev->no_dpd_cal
> > variable, set it based on USB ID (using usb_device_id->driver_info) and
> > do not perfrom calibration when it's set.
> 
> Hm… the struct usb_device already contains a u32 quirks. Shouldn't it
> be used instead, or is it used for an entirely different set of
> quirks?

Yes, those u32 quirks are used to change behaviour of usb-core module
and we should not interfere with them. We need quirk for mt7601u driver.

> > Also please clarify "work again" in the topic. Have your device ever
> > worked with mt7601u driver in some older kernel version?
> 
> Personally, my devices never worked. I ordered a bunch of them
> dirt-cheap from AliExpress, in early 2019. I needed one for my RPi,
> running OpenWrt 19.07 (Linux 4.19), but it failed the same way. I
> thought it might be a problem with the driver on ARM, I replaced it
> with a Ralink adapter and it worked fine. I hadn't used the devices
> until a couple of days ago, when I needed to connect a x86 machine and
> saw the exact same error I had seen on the Pi.

Ok, please correct the topic of the patch when you'll be posting next
version. 

Thanks
Stanislaw