linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: lorenzo@kernel.org, kuba@kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH] mt7601u: make the driver work again
Date: Wed, 5 May 2021 15:25:13 +0200	[thread overview]
Message-ID: <20210505132513.GA759295@wp.pl> (raw)
In-Reply-To: <CALjTZvausPmK+AubwcV71b1Vi+JxN23fM-AfUr1+jRD+NbnW1g@mail.gmail.com>

Hi

On Wed, May 05, 2021 at 10:38:58AM +0100, Rui Salvaterra wrote:
> Hi again, Stanislaw,
> 
> I was meanwhile wondering if we could try and unconditionally drop the
> DPD calibration from the driver, and see if anyone complains. You said
> it yourself [1] the vendor driver has DPD calibration under
> conditional compilation (I don't know which conditions, though, I
> haven't looked at it). As far as testing is concerned, all my devices
> are 148f:7601, so it would be nice for people with other USB IDs to
> test them.
> 
> [1] https://github.com/kuba-moo/mt7601u/issues/64#issuecomment-479801642

I don't know if it's safe to remove DPD calibration in mt7601u driver
for all supported devices. Possibly it is. I don't have my device any
longer, but as far I remember removing DPD was harmless for my device.
But can not assure that this does not break support for some other
devices or cause not easy to notice issue like performance drop on
some specific conditions.

Regards
Stanislaw

  reply	other threads:[~2021-05-05 13:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04 21:28 [RFC PATCH] mt7601u: make the driver work again Rui Salvaterra
2021-05-05  4:50 ` Stanislaw Gruszka
2021-05-05  8:01   ` Rui Salvaterra
2021-05-05  9:25     ` Stanislaw Gruszka
2021-05-05  9:38       ` Rui Salvaterra
2021-05-05 13:25         ` Stanislaw Gruszka [this message]
2021-05-11 10:13           ` Rui Salvaterra
2021-05-11 10:16             ` Colin Ian King
2021-05-11 10:21               ` Rui Salvaterra
2021-05-11 10:26                 ` Colin Ian King
2021-05-11 11:58                   ` Rui Salvaterra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210505132513.GA759295@wp.pl \
    --to=stf_xl@wp.pl \
    --cc=kuba@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=rsalvaterra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).