From: "Michael Büsch" <m@bues.ch>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: "John W . Linville" <linville@tuxdriver.com>,
"David S . Miller" <davem@davemloft.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/1] ssb: Fix error return code in ssb_bus_scan()
Date: Sat, 15 May 2021 16:52:54 +0200 [thread overview]
Message-ID: <20210515165254.248647d0@wiggum> (raw)
In-Reply-To: <20210515072949.7151-1-thunder.leizhen@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 562 bytes --]
On Sat, 15 May 2021 15:29:49 +0800
Zhen Lei <thunder.leizhen@huawei.com> wrote:
> Fix to return -EINVAL from the error handling case instead of 0, as done
> elsewhere in this function.
> @@ -325,6 +325,7 @@ int ssb_bus_scan(struct ssb_bus *bus,
> if (bus->nr_devices > ARRAY_SIZE(bus->devices)) {
> pr_err("More than %d ssb cores found (%d)\n",
> SSB_MAX_NR_CORES, bus->nr_devices);
> + err = -EINVAL;
> goto err_unmap;
> }
> if (bus->bustype == SSB_BUSTYPE_SSB) {
Acked-by: Michael Büsch <m@bues.ch>
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-05-15 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 7:29 [PATCH 1/1] ssb: Fix error return code in ssb_bus_scan() Zhen Lei
2021-05-15 14:52 ` Michael Büsch [this message]
2021-06-15 10:10 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210515165254.248647d0@wiggum \
--to=m@bues.ch \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).