From: Kalle Valo <kvalo@codeaurora.org>
To: "Alvin Šipraga" <ALSI@bang-olufsen.dk>
Cc: "Arend van Spriel" <aspriel@gmail.com>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Chi-hsien Lin" <chi-hsien.lin@infineon.com>,
"Wright Feng" <wright.feng@infineon.com>,
"Chung-hsien Hsu" <chung-hsien.hsu@infineon.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"brcm80211-dev-list.pdl@broadcom.com"
<brcm80211-dev-list.pdl@broadcom.com>,
"SHA-cyfmac-dev-list@infineon.com"
<SHA-cyfmac-dev-list@infineon.com>,
"Alvin Šipraga" <ALSI@bang-olufsen.dk>
Subject: Re: [1/2] brcmfmac: fix setting of station info chains bitmask
Date: Tue, 15 Jun 2021 10:36:58 +0000 (UTC) [thread overview]
Message-ID: <20210615103658.174A9C43460@smtp.codeaurora.org> (raw)
In-Reply-To: <20210506132010.3964484-1-alsi@bang-olufsen.dk>
Alvin Šipraga <ALSI@bang-olufsen.dk> wrote:
> The sinfo->chains field is a bitmask for filled values in chain_signal
> and chain_signal_avg, not a count. Treat it as such so that the driver
> can properly report per-chain RSSI information.
>
> Before (MIMO mode):
>
> $ iw dev wlan0 station dump
> ...
> signal: -51 [-51] dBm
>
> After (MIMO mode):
>
> $ iw dev wlan0 station dump
> ...
> signal: -53 [-53, -54] dBm
>
> Fixes: cae355dc90db ("brcmfmac: Add RSSI information to get_station.")
> Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
2 patches applied to wireless-drivers-next.git, thanks.
feb456437621 brcmfmac: fix setting of station info chains bitmask
9a1590934d9a brcmfmac: correctly report average RSSI in station info
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210506132010.3964484-1-alsi@bang-olufsen.dk/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-06-15 10:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 13:20 [PATCH 1/2] brcmfmac: fix setting of station info chains bitmask Alvin Šipraga
2021-05-06 13:20 ` [PATCH 2/2] brcmfmac: correctly report average RSSI in station info Alvin Šipraga
2021-06-14 13:21 ` [PATCH 1/2] brcmfmac: fix setting of station info chains bitmask Alvin Šipraga
2021-06-14 14:33 ` Kalle Valo
2021-06-14 17:18 ` Alvin Šipraga
2021-06-15 10:36 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615103658.174A9C43460@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ALSI@bang-olufsen.dk \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=chi-hsien.lin@infineon.com \
--cc=chung-hsien.hsu@infineon.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox