From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A006C4743C for ; Wed, 23 Jun 2021 19:26:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AEE261075 for ; Wed, 23 Jun 2021 19:26:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229906AbhFWT2o (ORCPT ); Wed, 23 Jun 2021 15:28:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbhFWT2o (ORCPT ); Wed, 23 Jun 2021 15:28:44 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BC6EC061574; Wed, 23 Jun 2021 12:26:26 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id j2so5946825lfg.9; Wed, 23 Jun 2021 12:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1mws8JTsPd9+atb1/JRjdmcWQnXTwDM12m7T79JCDYI=; b=QKbruPrK8+r9Z6CHz8ZcBN91/61A8PbpooA0sGui9NBKFgMuuMLoyIVLMKCtsLHdeO O3otQ5Z8TPQ3mNDvuIah4gK6NE2M8mDny2i0V4zqrPkmEBomA/Q7hJUhNY5LSAfNWeyk YCakA62FspbPtZEMfcp4uNba1bU/SgJV8zIImpK/P61wRhP8ktrcdMoNxNzCdNm4skYf +PJ5wjDyv90wNzAAJe1kLHVXvj+bfKbj94AoZT2J5y2wMi78x/Otyg3O+4MFiv6cdEAh wnlBsPoAqJq+QtplRzV921rSgv7G2ohU7KVABXL9i5kisZGcI4U0MgFg/v98SChDv3Ry axWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1mws8JTsPd9+atb1/JRjdmcWQnXTwDM12m7T79JCDYI=; b=Y4Q4CH8RAxUkXNbL4eFNeNIEkoA1dV+0KyfsoV2DHYSHvxZHTwYg3W2waS7YmuislG tCRotPZ3WHKr951I7r4GXuzMGelbxNUBp7pGMkg2sB576qW3tanvyf7qjpxKqFax2TXP QJ3bk1UvthbOWj3F5kgKYJzQws+oJFFEveeU1O+T4wZRha8dllKxMTCDT6pE/AjzfJze xve3aZdbOJf5OGzcO/fCOqmxbxaaD/hdOQJotXQCPNeDprr8OMOvrJ9cuOnZ5D8GObHM bmBO3SaVPfhq4Bxg7nkQlycEK/cb9riLpZUAJQv18SLMnVqEfgAt3OAwfd16zljN2dDK G7NA== X-Gm-Message-State: AOAM532jcjXvprogBhN+oNVL8dTKK4TRuX4mt7IYqytozDcrL5ZwYOK2 aHcsh+ZU2yDF07+8hmjXp/k= X-Google-Smtp-Source: ABdhPJx/y3z1NxEj0i19lW89L1QoDy9Hp6WsBpHJ7H8yUQyHKJpyoJlgX9mJBjXKMibgHc5AndiiIQ== X-Received: by 2002:ac2:4c48:: with SMTP id o8mr876420lfk.332.1624476384620; Wed, 23 Jun 2021 12:26:24 -0700 (PDT) Received: from localhost.localdomain ([94.103.225.155]) by smtp.gmail.com with ESMTPSA id p5sm50912ljn.109.2021.06.23.12.26.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 12:26:24 -0700 (PDT) Date: Wed, 23 Jun 2021 22:26:20 +0300 From: Pavel Skripkin To: Christian Lamparter Cc: kvalo@codeaurora.org, davem@davemloft.net, Yang Yingliang , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH] net: ath10: add missing ret initialization Message-ID: <20210623222620.06b6335a@gmail.com> In-Reply-To: References: <20210623191426.13648-1-paskripkin@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 23 Jun 2021 21:23:27 +0200 Christian Lamparter wrote: > On 23/06/2021 21:14, Pavel Skripkin wrote: > > In case of not supported chip the code jump > > to the error handling path, but _ret_ will be set to 0. > > Returning 0 from probe means, that ->probe() succeeded, but > > it's not true when chip is not supported. > > > > Fixes: f8914a14623a ("ath10k: restore QCA9880-AR1A (v1) detection") > > Signed-off-by: Pavel Skripkin > > I think this is already fixed by: > > commit e2783e2f39ba99178dedfc1646d5cc0979d1bab3 > Author: Yang Yingliang > Date: Mon May 31 17:41:28 2021 +0300 > > ath10k: add missing error return code in ath10k_pci_probe() > > Ah, i didn't check linux-next tree, my bad :( Thanks for pointing it out With regards, Pavel Skripkin