From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2365C49EA6 for ; Thu, 24 Jun 2021 16:23:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA832613C1 for ; Thu, 24 Jun 2021 16:23:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229831AbhFXQZp (ORCPT ); Thu, 24 Jun 2021 12:25:45 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:29442 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231321AbhFXQZo (ORCPT ); Thu, 24 Jun 2021 12:25:44 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1624551805; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=R0lETgBdGcijzvZsCQBUp+QN1WHLCayTzZXt/0GElcM=; b=d8RAd+EyQ7MbNPm4qRpBl0mdaCKkzeAK90tKxKrXdnlckmybPuNFdTbOJY85ppmYq+kH1y80 R6+QYkSXS/CYIw16fARsL6FS+V9koine93Xa6tnlB2YKSmc6vYLLuLckt+vu/OJqMq3MeKQE yfe/BX5i1ZmvuCX4JwfyQatHR9s= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 60d4b105dc4628fe7ec079bf (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 24 Jun 2021 16:21:25 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 8E898C433F1; Thu, 24 Jun 2021 16:21:24 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 83769C433D3; Thu, 24 Jun 2021 16:21:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 83769C433D3 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] rtw88: fix c2h memory leak From: Kalle Valo In-Reply-To: <20210624023459.10294-1-pkshih@realtek.com> References: <20210624023459.10294-1-pkshih@realtek.com> To: Ping-Ke Shih Cc: , , User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210624162124.8E898C433F1@smtp.codeaurora.org> Date: Thu, 24 Jun 2021 16:21:24 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ping-Ke Shih wrote: > From: Po-Hao Huang > > Fix erroneous code that leads to unreferenced objects. During H2C > operations, some functions returned without freeing the memory that only > the function have access to. Release these objects when they're no longer > needed to avoid potentially memory leaks. > > Signed-off-by: Po-Hao Huang > Signed-off-by: Ping-Ke Shih Patch applied to wireless-drivers-next.git, thanks. 1d8820d5462d rtw88: fix c2h memory leak -- https://patchwork.kernel.org/project/linux-wireless/patch/20210624023459.10294-1-pkshih@realtek.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches