From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11F81C432BE for ; Sat, 21 Aug 2021 17:50:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE7AF60F42 for ; Sat, 21 Aug 2021 17:50:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234680AbhHURvP (ORCPT ); Sat, 21 Aug 2021 13:51:15 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:50107 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231368AbhHURvO (ORCPT ); Sat, 21 Aug 2021 13:51:14 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1629568235; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=ctxiQcX4qsO4AfpsVtAdyDLSagP5vHWXtonW9I/Mmjg=; b=DBk+qJPDdgELWF5reOhsqjA4k7y+PXMwHXtsnj6n04jjuozKperZM9wXc0car0is7u9jbwHA xzYE6UbulFW32eppJygInw80a4n9vE9oOFhGwMzcDgpdYXjRuxsFzfPDKc6Imn1cbgi00/En CeynF93zj4vqfULtwBrNbbrPzds= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 61213ce8f588e42af154c611 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 21 Aug 2021 17:50:32 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A0F69C43617; Sat, 21 Aug 2021 17:50:32 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id C8FB1C4338F; Sat, 21 Aug 2021 17:50:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org C8FB1C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] mwifiex: make arrays static const, makes object smaller From: Kalle Valo In-Reply-To: <20210819121651.7566-1-colin.king@canonical.com> References: <20210819121651.7566-1-colin.king@canonical.com> To: Colin King Cc: Amitkumar Karwar , Ganapathi Bhat , Sharvari Harisangam , Xinming Hu , "David S . Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210821175032.A0F69C43617@smtp.codeaurora.org> Date: Sat, 21 Aug 2021 17:50:32 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Colin King wrote: > From: Colin Ian King > > Don't populate the arrays wpa_oui and wps_oui on the stack but > instead them static const. Makes the object code smaller by 63 bytes: > > Before: > text data bss dec hex filename > 29453 5451 64 34968 8898 .../wireless/marvell/mwifiex/sta_ioctl.o > > After: > text data bss dec hex filename > 29356 5611 64 35031 88d7 ../wireless/marvell/mwifiex/sta_ioctl.o > > (gcc version 10.3.0) > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. da2c9cedc0d0 mwifiex: make arrays static const, makes object smaller -- https://patchwork.kernel.org/project/linux-wireless/patch/20210819121651.7566-1-colin.king@canonical.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches