From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Karthikeyan Periyasamy <periyasa@codeaurora.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ath11k: fix some sleeping in atomic bugs
Date: Tue, 28 Sep 2021 10:55:59 +0000 (UTC) [thread overview]
Message-ID: <20210928105559.EAE19C43616@smtp.codeaurora.org> (raw)
In-Reply-To: <20210812070434.GE31863@kili>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The ath11k_dbring_bufs_replenish() and ath11k_dbring_fill_bufs()
> take a "gfp" parameter but they since they take spinlocks, the
> allocations they do have to be atomic. This causes a bug because
> ath11k_dbring_buf_setup passes GFP_KERNEL for the gfp flags.
>
> The fix is to use GFP_ATOMIC and remove the unused parameters.
>
> Fixes: bd6478559e27 ("ath11k: Add direct buffer ring support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
aadf7c81a077 ath11k: fix some sleeping in atomic bugs
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210812070434.GE31863@kili/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-09-28 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 7:04 [PATCH] ath11k: fix some sleeping in atomic bugs Dan Carpenter
2021-09-28 10:55 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928105559.EAE19C43616@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=periyasa@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox