Re: [PATCH v1] ath10k: fetch (pre-)calibration data via nvmem subsystem

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3076 bytes --]

Hi Christian,

I love your patch! Perhaps something to improve:

[auto build test WARNING on kvalo-ath/ath-next]
[also build test WARNING on kvalo-wireless-drivers-next/master kvalo-wireless-drivers/master v5.15-rc5 next-20211015]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Christian-Lamparter/ath10k-fetch-pre-calibration-data-via-nvmem-subsystem/20211016-041140
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next
config: i386-randconfig-c001-20211015 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 6069a6a5049497a32a50a49661c2f4169078bdba)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9a08dd8f5ae4d035f503db3a64ed4c6869b038e3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Christian-Lamparter/ath10k-fetch-pre-calibration-data-via-nvmem-subsystem/20211016-041140
        git checkout 9a08dd8f5ae4d035f503db3a64ed4c6869b038e3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/ath/ath10k/core.c:1879:19: warning: format specifies type 'long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
                               cell_name, len, ar->hw_params.cal_data_len);
                                          ^~~
   1 warning generated.


vim +1879 drivers/net/wireless/ath/ath10k/core.c

  1858	
  1859	static int ath10k_download_cal_nvmem(struct ath10k *ar, const char *cell_name)
  1860	{
  1861		struct nvmem_cell *cell;
  1862		void *buf;
  1863		size_t len;
  1864		int ret;
  1865	
  1866		cell = devm_nvmem_cell_get(ar->dev, cell_name);
  1867		if (IS_ERR(cell)) {
  1868			ret = PTR_ERR(cell);
  1869			return ret;
  1870		}
  1871	
  1872		buf = nvmem_cell_read(cell, &len);
  1873		if (IS_ERR(buf))
  1874			return PTR_ERR(buf);
  1875	
  1876		if (ar->hw_params.cal_data_len != len) {
  1877			kfree(buf);
  1878			ath10k_warn(ar, "invalid calibration data length in nvmem-cell '%s': %ld != %d\n",
> 1879				    cell_name, len, ar->hw_params.cal_data_len);
  1880			return -EMSGSIZE;
  1881		}
  1882	
  1883		ret = ath10k_download_board_data(ar, buf, len);
  1884		kfree(buf);
  1885		if (ret)
  1886			ath10k_warn(ar, "failed to download calibration data from nvmem-cell '%s': %d\n",
  1887				    cell_name, ret);
  1888	
  1889		return ret;
  1890	}
  1891	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42120 bytes --]