Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

Kalle Valo
2020-09-30T08:06:46Z

Leon Romanovsky <leon@kernel.org> writes:

>> --- /dev/null
>> +++ b/drivers/net/wireless/purelifi/Kconfig
>> @@ -0,0 +1,38 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +config WLAN_VENDOR_PURELIFI
>> + bool "pureLiFi devices"
>> + default y
>
> "N" is preferred default.
>
>> + help
>> + If you have a pureLiFi device, say Y.
>> +
>> + Note that the answer to this question doesn't directly affect the
>> + kernel: saying N will just cause the configurator to skip all the
>> + questions about these cards. If you say Y, you will be asked for
>> + your specific card in the following questions.
>
> The text above makes no sense. Of course, it makes a lot of sense to
> disable this device for whole world.

This is a standard text for all vendor "groups", the actual driver
should be selected in a separate config. This text has been copied from
NET_VENDOR_ groups and used by all WLAN_VENDOR configs (or at least that
was the original plan).

--