Re: [PATCH] [v11] wireless: Initial driver submission for pureLiFi STA devices

Kalle Valo
2020-12-21T05:58:53Z

Srinivasan Raju <srini.raju@purelifi.com> writes:

>> I see lots of magic numbers in the driver like 2, 0x33 and 0x34 here.
>> Please convert the magic numbers to proper defines explaining the
>> meaning. And for vendor commands you could even use enum to group
>> them better in .h file somewhere.
>
> Hi Kalle,
>
> Thanks for reviewing the driver, We will work on the comments.

I haven't had time to do a throrough review yet, but I suggest fixing
the stuff I commented and submitting v12. I'll then do a new review with
v12.

--