From: Alison Schofield <alison.schofield@intel.com>
To: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
Cc: outreachy@lists.linux.dev, toke@toke.dk, kvalo@kernel.org,
davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] First Patch: Add Printk to pci.c
Date: Mon, 28 Mar 2022 18:05:16 -0700 [thread overview]
Message-ID: <20220329010516.GA1166534@alison-desk> (raw)
In-Reply-To: <20220328232449.132550-1-eng.alaamohamedsoliman.am@gmail.com>
On Tue, Mar 29, 2022 at 01:24:49AM +0200, Alaa Mohamed wrote:
> This patch for adding Printk line to ath9k probe function as a task
> for Outreachy internship
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
Hi Alaa,
Based on your 'CC to outreachy I can guess you are following out 'First
Patch Tutorial'. A patch for this step does not need to be sent out to
the maintainers and lists, since it's not something we actually want
to change in the Linux Kernel.
Your next patch, a cleanup patch in drivers/staging/ does need to get
sent. I guess we'll see that soon!
Thanks & welcome to this round of Outreachy,
Alison
> ---
> drivers/net/wireless/ath/ath9k/pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath9k/pci.c b/drivers/net/wireless/ath/ath9k/pci.c
> index a074e23013c5..e16bdf343a2f 100644
> --- a/drivers/net/wireless/ath/ath9k/pci.c
> +++ b/drivers/net/wireless/ath/ath9k/pci.c
> @@ -892,6 +892,7 @@ static int ath_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> int ret = 0;
> char hw_name[64];
> int msi_enabled = 0;
> + printk(KERN_DEBUG "I can modify the Linux kernel!\n");
>
> if (pcim_enable_device(pdev))
> return -EIO;
> --
> 2.35.1
>
>
next prev parent reply other threads:[~2022-03-29 1:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 23:24 [PATCH] First Patch: Add Printk to pci.c Alaa Mohamed
2022-03-29 1:05 ` Alison Schofield [this message]
2022-03-29 1:16 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329010516.GA1166534@alison-desk \
--to=alison.schofield@intel.com \
--cc=davem@davemloft.net \
--cc=eng.alaamohamedsoliman.am@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=outreachy@lists.linux.dev \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox