From: kernel test robot <lkp@intel.com>
To: Ping-Ke Shih <pkshih@realtek.com>, kvalo@kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 15/15] rtw89: 8852c: add 8852ce to Makefile and Kconfig
Date: Fri, 29 Apr 2022 08:45:30 +0800 [thread overview]
Message-ID: <202204290830.slUaIhad-lkp@intel.com> (raw)
In-Reply-To: <20220426063235.41650-16-pkshih@realtek.com>
Hi Ping-Ke,
I love your patch! Perhaps something to improve:
[auto build test WARNING on wireless-next/main]
[also build test WARNING on next-20220428]
[cannot apply to wireless/main v5.18-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Ping-Ke-Shih/rtw89-8852c-add-RFK-and-then-enable-8852ce-in-Makefile-and-Kconfig/20220426-143456
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20220429/202204290830.slUaIhad-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c59473aacce38cd7dd77eebceaf3c98c5707ab3b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/5aaabdd4d9ac433ed14c1c02147c2609827739d2
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Ping-Ke-Shih/rtw89-8852c-add-RFK-and-then-enable-8852ce-in-Makefile-and-Kconfig/20220426-143456
git checkout 5aaabdd4d9ac433ed14c1c02147c2609827739d2
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/wireless/realtek/rtw89/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/wireless/realtek/rtw89/rtw8852c.c:2640:2: warning: result of comparison of constant 18446744073709551615 with expression of type 'typeof (_Generic((__msk), char: (unsigned char)0, unsigned char: (unsigned char)0, signed char: (unsigned char)0, unsigned short: (unsigned short)0, short: (unsigned short)0, unsigned int: (unsigned int)0, int: (unsigned int)0, unsigned long: (unsigned long)0, long: (unsigned long)0, unsigned long long: (unsigned long long)0, long long: (unsigned long long)0, default: (__msk)))' (aka 'unsigned long') is always false [-Wtautological-constant-out-of-range-compare]
__write_ctrl(R_AX_PWR_RATE_CTRL, B_AX_FORCE_PWR_BY_RATE_VALUE_MASK,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw89/rtw8852c.c:2621:13: note: expanded from macro '__write_ctrl'
u32 _wrt = FIELD_PREP(__msk, _val); \
^~~~~~~~~~~~~~~~~~~~~~~
include/linux/bitfield.h:114:3: note: expanded from macro 'FIELD_PREP'
__BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bitfield.h:71:53: note: expanded from macro '__BF_FIELD_CHECK'
BUILD_BUG_ON_MSG(__bf_cast_unsigned(_mask, _mask) > \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
include/linux/compiler_types.h:352:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:340:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:332:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
drivers/net/wireless/realtek/rtw89/rtw8852c.c:2653:2: warning: result of comparison of constant 18446744073709551615 with expression of type 'typeof (_Generic((__msk), char: (unsigned char)0, unsigned char: (unsigned char)0, signed char: (unsigned char)0, unsigned short: (unsigned short)0, short: (unsigned short)0, unsigned int: (unsigned int)0, int: (unsigned int)0, unsigned long: (unsigned long)0, long: (unsigned long)0, unsigned long long: (unsigned long long)0, long long: (unsigned long long)0, default: (__msk)))' (aka 'unsigned long') is always false [-Wtautological-constant-out-of-range-compare]
__write_ctrl(R_AX_PWR_COEXT_CTRL, B_AX_TXAGC_BT_MASK, val,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw89/rtw8852c.c:2621:13: note: expanded from macro '__write_ctrl'
u32 _wrt = FIELD_PREP(__msk, _val); \
^~~~~~~~~~~~~~~~~~~~~~~
include/linux/bitfield.h:114:3: note: expanded from macro 'FIELD_PREP'
__BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bitfield.h:71:53: note: expanded from macro '__BF_FIELD_CHECK'
BUILD_BUG_ON_MSG(__bf_cast_unsigned(_mask, _mask) > \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
include/linux/compiler_types.h:352:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:340:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:332:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
2 warnings generated.
vim +2640 drivers/net/wireless/realtek/rtw89/rtw8852c.c
2fb822f82a59db Ping-Ke Shih 2022-04-21 2630
2fb822f82a59db Ping-Ke Shih 2022-04-21 2631 switch (arg.ctrl_all_time) {
2fb822f82a59db Ping-Ke Shih 2022-04-21 2632 case 0xffff:
2fb822f82a59db Ping-Ke Shih 2022-04-21 2633 val = 0;
2fb822f82a59db Ping-Ke Shih 2022-04-21 2634 break;
2fb822f82a59db Ping-Ke Shih 2022-04-21 2635 default:
2fb822f82a59db Ping-Ke Shih 2022-04-21 2636 val = arg.all_time.data;
2fb822f82a59db Ping-Ke Shih 2022-04-21 2637 break;
2fb822f82a59db Ping-Ke Shih 2022-04-21 2638 }
2fb822f82a59db Ping-Ke Shih 2022-04-21 2639
2fb822f82a59db Ping-Ke Shih 2022-04-21 @2640 __write_ctrl(R_AX_PWR_RATE_CTRL, B_AX_FORCE_PWR_BY_RATE_VALUE_MASK,
2fb822f82a59db Ping-Ke Shih 2022-04-21 2641 val, B_AX_FORCE_PWR_BY_RATE_EN,
2fb822f82a59db Ping-Ke Shih 2022-04-21 2642 arg.ctrl_all_time != 0xffff);
2fb822f82a59db Ping-Ke Shih 2022-04-21 2643
2fb822f82a59db Ping-Ke Shih 2022-04-21 2644 switch (arg.ctrl_gnt_bt) {
2fb822f82a59db Ping-Ke Shih 2022-04-21 2645 case 0xffff:
2fb822f82a59db Ping-Ke Shih 2022-04-21 2646 val = 0;
2fb822f82a59db Ping-Ke Shih 2022-04-21 2647 break;
2fb822f82a59db Ping-Ke Shih 2022-04-21 2648 default:
2fb822f82a59db Ping-Ke Shih 2022-04-21 2649 val = arg.gnt_bt.data;
2fb822f82a59db Ping-Ke Shih 2022-04-21 2650 break;
2fb822f82a59db Ping-Ke Shih 2022-04-21 2651 };
2fb822f82a59db Ping-Ke Shih 2022-04-21 2652
2fb822f82a59db Ping-Ke Shih 2022-04-21 2653 __write_ctrl(R_AX_PWR_COEXT_CTRL, B_AX_TXAGC_BT_MASK, val,
2fb822f82a59db Ping-Ke Shih 2022-04-21 2654 B_AX_TXAGC_BT_EN, arg.ctrl_gnt_bt != 0xffff);
2fb822f82a59db Ping-Ke Shih 2022-04-21 2655
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-04-29 0:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 6:32 [PATCH 00/15] rtw89: 8852c: add RFK and then enable 8852ce in Makefile and Kconfig Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 01/15] rtw89: 8852c: rfk: add RFK tables Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 02/15] rtw89: 8852c: rfk: add DACK Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 03/15] rtw89: 8852c: rfk: add LCK Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 04/15] rtw89: 8852c: rfk: add TSSI Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 05/15] rtw89: 8852c: rfk: add RCK Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 06/15] rtw89: 8852c: rfk: add RX DCK Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 07/15] rtw89: 8852c: rfk: add IQK Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 08/15] rtw89: 8852c: rfk: add DPK Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 09/15] rtw89: 8852c: rfk: get calibrated channels to notify firmware Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 10/15] rtw89: 8852c: add chip_ops::bb_ctrl_btc_preagc Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 11/15] rtw89: 8852c: add basic and remaining chip_info Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 12/15] rtw89: ps: fine tune polling interval while changing low power mode Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 13/15] rtw89: correct AID settings of beamformee Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 14/15] rtw89: 8852c: correct register definitions used by 8852c Ping-Ke Shih
2022-04-26 6:32 ` [PATCH 15/15] rtw89: 8852c: add 8852ce to Makefile and Kconfig Ping-Ke Shih
2022-04-29 0:45 ` kernel test robot [this message]
2022-04-29 5:30 ` Pkshih
2022-04-29 5:52 ` Kalle Valo
2022-04-29 7:25 ` Pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204290830.slUaIhad-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).