Re: [PATCH wireless-next 0/3] wifi: netif_napi_add() conversions

[Jakub Kicinski <kuba@kernel.org>]

On Thu, 05 May 2022 07:25:03 +0300 Kalle Valo wrote:
> Jakub Kicinski <kuba@kernel.org> writes:
> 
> > Convert wifi callers to the new netif_napi_add() APIs.
> >
> > The callers passing 64 or NAPI_POLL_WEIGHT to the non-Tx flavor
> > are left alone. I'm planning to include wifi drivers in the massive
> > tree-wide patch/series which will drop the last argument from
> > netif_napi_add(). Alternatively I can switch all of wifi to
> > netif_napi_add_tx_weight() and back after the netif_napi_add()
> > change makes its wait into wireless-next.
> > Please LMK if you prefer that.
> >
> > Jakub Kicinski (3):
> >   wifi: wil6210: switch to netif_napi_add_tx()
> >   wifi: mt76: switch to netif_napi_add_tx()
> >   wifi: qtnfmac: switch to netif_napi_add_weight()  
> 
> We don't use that "wifi:" prefix, otherwise looks good. 

I know, my silent effort to make git log --oneline be more
understandable for folks outside of networking is not really
being met with much applause :) Ethernet people also don't
like the "eth:" prefix..

AFAICS drivers tend to use a format consisting of (numbers at 
the top denoting commonality):

3    4       1       2
net: vendor: driver: component: bla bla

Driver name is the most common prefix. It is the most meaningful
and natural for people working on the code. Not everyone is working 
on the driver code, tho.

1) When I send PRs to Linus I always wonder how much he can 
make out of the shortlog. And if people throw "net:" into the mix
whether it's still clear when something is "just" a driver bug vs
a core bug affecting everyone. So I started using "eth: " for ethernet
drivers, and "wifi: " for wireless drivers in the text of the PRs.

2) For people doing backporting the driver names may not be meaningful,
but if I'm doing backports for a datacenter kernel I know to pay
attention to "eth:" while "wifi:" I can safely skip.

3) The case of this set - I have conversions for the entire tree queued
up on a branch, it's quite useful for me to use a common area-specific
prefix to see what goes were.

Anyway, that's just me rambling. I hope you don't mind if I send things
with a wifi prefix from time to time given it's a convenient way for me
to mark the queued patches.

> Feel free to take via your tree:
> 
> Acked-by: Kalle Valo <kvalo@kernel.org>

Actually I didn't cc netdev so would be easier if you could take them :)
I have to wait for RDMA/infiniband to get merged up before I can start
deleting stuff anyway :(