From: kernel test robot <lkp@intel.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com,
Jakub Kicinski <kuba@kernel.org>,
Stefan Schmidt <stefan@datenfreihafen.org>,
johannes@sipsolutions.net, alex.aring@gmail.com,
mareklindner@neomailbox.ch, sw@simonwunderlich.de, a@unstable.cc,
sven@narfation.org, linux-wireless@vger.kernel.org,
linux-wpan@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: ifdefy the wireless pointers in struct net_device
Date: Thu, 19 May 2022 04:31:31 +0800 [thread overview]
Message-ID: <202205190456.MohbzV8M-lkp@intel.com> (raw)
In-Reply-To: <20220518181807.2030747-1-kuba@kernel.org>
Hi Jakub,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Jakub-Kicinski/net-ifdefy-the-wireless-pointers-in-struct-net_device/20220519-022305
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git a3641ca416a3da7cbeae5bcf1fc26ba9797a1438
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220519/202205190456.MohbzV8M-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/c6413242ee18dfc005d7ed7ccc4db9cf7883b872
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Jakub-Kicinski/net-ifdefy-the-wireless-pointers-in-struct-net_device/20220519-022305
git checkout c6413242ee18dfc005d7ed7ccc4db9cf7883b872
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/core/net-sysfs.c: In function 'netdev_register_kobject':
>> net/core/net-sysfs.c:2013:30: error: 'wireless_group' undeclared (first use in this function); did you mean 'wireless_dev'?
2013 | *groups++ = &wireless_group;
| ^~~~~~~~~~~~~~
| wireless_dev
net/core/net-sysfs.c:2013:30: note: each undeclared identifier is reported only once for each function it appears in
vim +2013 net/core/net-sysfs.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 1990
^1da177e4c3f41 Linus Torvalds 2005-04-16 1991 /* Create sysfs entries for network device. */
6b53dafe23fd1f WANG Cong 2014-07-23 1992 int netdev_register_kobject(struct net_device *ndev)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1993 {
6648c65e7ea72c stephen hemminger 2017-08-18 1994 struct device *dev = &ndev->dev;
6b53dafe23fd1f WANG Cong 2014-07-23 1995 const struct attribute_group **groups = ndev->sysfs_groups;
0a9627f2649a02 Tom Herbert 2010-03-16 1996 int error = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1997
a1b3f594dc5faa Eric W. Biederman 2010-05-04 1998 device_initialize(dev);
43cb76d91ee85f Greg Kroah-Hartman 2002-04-09 1999 dev->class = &net_class;
6b53dafe23fd1f WANG Cong 2014-07-23 2000 dev->platform_data = ndev;
43cb76d91ee85f Greg Kroah-Hartman 2002-04-09 2001 dev->groups = groups;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2002
6b53dafe23fd1f WANG Cong 2014-07-23 2003 dev_set_name(dev, "%s", ndev->name);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2004
8b41d1887db718 Eric W. Biederman 2007-09-26 2005 #ifdef CONFIG_SYSFS
0c509a6c9393b2 Eric W. Biederman 2009-10-29 2006 /* Allow for a device specific group */
0c509a6c9393b2 Eric W. Biederman 2009-10-29 2007 if (*groups)
0c509a6c9393b2 Eric W. Biederman 2009-10-29 2008 groups++;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2009
0c509a6c9393b2 Eric W. Biederman 2009-10-29 2010 *groups++ = &netstat_group;
38c1a01cf10c6e Johannes Berg 2012-11-16 2011
c6413242ee18df Jakub Kicinski 2022-05-18 2012 if (wireless_group_needed(ndev))
38c1a01cf10c6e Johannes Berg 2012-11-16 @2013 *groups++ = &wireless_group;
8b41d1887db718 Eric W. Biederman 2007-09-26 2014 #endif /* CONFIG_SYSFS */
^1da177e4c3f41 Linus Torvalds 2005-04-16 2015
0a9627f2649a02 Tom Herbert 2010-03-16 2016 error = device_add(dev);
0a9627f2649a02 Tom Herbert 2010-03-16 2017 if (error)
8ed633b9baf9ec Wang Hai 2019-04-12 2018 return error;
0a9627f2649a02 Tom Herbert 2010-03-16 2019
6b53dafe23fd1f WANG Cong 2014-07-23 2020 error = register_queue_kobjects(ndev);
8ed633b9baf9ec Wang Hai 2019-04-12 2021 if (error) {
8ed633b9baf9ec Wang Hai 2019-04-12 2022 device_del(dev);
8ed633b9baf9ec Wang Hai 2019-04-12 2023 return error;
8ed633b9baf9ec Wang Hai 2019-04-12 2024 }
0a9627f2649a02 Tom Herbert 2010-03-16 2025
9802c8e22f6efd Ming Lei 2013-02-22 2026 pm_runtime_set_memalloc_noio(dev, true);
9802c8e22f6efd Ming Lei 2013-02-22 2027
0a9627f2649a02 Tom Herbert 2010-03-16 2028 return error;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2029 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 2030
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-05-18 20:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 18:18 [PATCH net-next v2] net: ifdefy the wireless pointers in struct net_device Jakub Kicinski
2022-05-18 18:59 ` Johannes Berg
2022-05-18 19:29 ` Jakub Kicinski
2022-05-18 20:31 ` kernel test robot [this message]
2022-05-19 6:53 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205190456.MohbzV8M-lkp@intel.com \
--to=lkp@intel.com \
--cc=a@unstable.cc \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stefan@datenfreihafen.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).