From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48C4AECAAD3 for ; Sat, 17 Sep 2022 13:21:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229567AbiIQNVl (ORCPT ); Sat, 17 Sep 2022 09:21:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbiIQNVj (ORCPT ); Sat, 17 Sep 2022 09:21:39 -0400 Received: from mx3.wp.pl (mx3.wp.pl [212.77.101.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1E732126F for ; Sat, 17 Sep 2022 06:21:37 -0700 (PDT) Received: (wp-smtpd smtp.wp.pl 22298 invoked from network); 17 Sep 2022 15:21:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1663420895; bh=nrePjWJEfo1bN1hzN7CYhPEEtXafH27RfEVwE+MenR0=; h=From:To:Cc:Subject; b=pR6oGpnrJvfDER2xYNSCER8y0dFDpAhoU4Fubpeq3MnKFEgLjTMt2uVfIebgu84Qa HoDrEKFyEjLiAVmCyHU61j8nKvdZh+gw50BaORVmsv4ijM0rwYjAeAS7fqPJONxFNY O5cAx8uFGdrvOF0wREzHHUxQ+VJRJpM2BDKPtMLQ= Received: from 89-64-7-128.dynamic.chello.pl (HELO localhost) (stf_xl@wp.pl@[89.64.7.128]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 17 Sep 2022 15:21:35 +0200 Date: Sat, 17 Sep 2022 15:21:34 +0200 From: Stanislaw Gruszka To: Daniel Golle Cc: linux-wireless@vger.kernel.org, Helmut Schaa , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Johannes Berg Subject: Re: [PATCH RESEND 01/15] rt2x00: define RF5592 in init_eeprom routine Message-ID: <20220917132134.GN17901@wp.pl> References: <20220917131052.GL17901@wp.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220917131052.GL17901@wp.pl> X-WP-MailID: b958f9740d737c40509916147241a859 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [QbP0] Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sat, Sep 17, 2022 at 03:10:53PM +0200, Stanislaw Gruszka wrote: > On Sat, Sep 17, 2022 at 12:04:21AM +0100, Daniel Golle wrote: > > From: Tomislav Požega > > > > This patch fixes following crash on Linksys EA2750 during 5GHz wifi > > init: > > > > [ 7.955153] rt2800pci 0000:01:00.0: card - bus=0x1, slot = 0x0 irq=4 > > [ 7.962259] rt2800pci 0000:01:00.0: loaded eeprom from mtd device "Factory" > > [ 7.969435] ieee80211 phy0: rt2x00_set_rt: Info - RT chipset 5592, rev 0222 detected > > [ 7.977348] ieee80211 phy0: rt2800_init_eeprom: Error - Invalid RF chipset 0x0000 detected > > [ 7.985793] ieee80211 phy0: rt2x00lib_probe_dev: Error - Failed to allocate device > > [ 7.993569] CPU 0 Unable to handle kernel paging request at virtual address 00000024, epc == 800c8f54, ra == 80249ff8 > > [ 8.004408] Oops[#1]: > > > > Signed-off-by: Tomislav Požega > > Please add your's signed-off-by and fix the changelog. Patch > fixes incorrect rf value encoded in eeprom, not a crash. IIRC > crash itself was caused by incorrect rt2x00->eeprom_file pointer, > happend when rt2800_init_eeprom() returned error. And should > be alredy fixed in openwrt tree. The crash was fixed by: https://patchwork.ozlabs.org/project/openwrt/patch/1551000198-30901-1-git-send-email-sgruszka@redhat.com/