* [PATCH][next] atmel: Fix atmel_private_handler array size
@ 2022-10-18 2:37 Kees Cook
2022-11-01 10:59 ` [next] wifi: " Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2022-10-18 2:37 UTC (permalink / raw)
To: Simon Kelley
Cc: Kees Cook, Kalle Valo, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-wireless, netdev, linux-kernel,
linux-hardening
Fix the atmel_private_handler to correctly sized (1 element) again. (I
should have checked the data segment for differences.) This had no
behavioral impact (no private callbacks), but it made a very large
zero-filled array.
Cc: Simon Kelley <simon@thekelleys.org.uk>
Cc: Kalle Valo <kvalo@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Fixes: 8af9d4068e86 ("wifi: atmel: Avoid clashing function prototypes")
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/net/wireless/atmel/atmel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/atmel/atmel.c b/drivers/net/wireless/atmel/atmel.c
index ed430b91e2aa..7c2d1c588156 100644
--- a/drivers/net/wireless/atmel/atmel.c
+++ b/drivers/net/wireless/atmel/atmel.c
@@ -2570,7 +2570,7 @@ static const iw_handler atmel_handler[] =
static const iw_handler atmel_private_handler[] =
{
- IW_HANDLER(SIOCIWFIRSTPRIV, NULL),
+ NULL, /* SIOCIWFIRSTPRIV */
};
struct atmel_priv_ioctl {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [next] wifi: atmel: Fix atmel_private_handler array size
2022-10-18 2:37 [PATCH][next] atmel: Fix atmel_private_handler array size Kees Cook
@ 2022-11-01 10:59 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-11-01 10:59 UTC (permalink / raw)
To: Kees Cook
Cc: Simon Kelley, Kees Cook, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-wireless, netdev, linux-kernel,
linux-hardening
Kees Cook <keescook@chromium.org> wrote:
> Fix the atmel_private_handler to correctly sized (1 element) again. (I
> should have checked the data segment for differences.) This had no
> behavioral impact (no private callbacks), but it made a very large
> zero-filled array.
>
> Cc: Simon Kelley <simon@thekelleys.org.uk>
> Cc: Kalle Valo <kvalo@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Fixes: 8af9d4068e86 ("wifi: atmel: Avoid clashing function prototypes")
> Signed-off-by: Kees Cook <keescook@chromium.org>
Patch applied to wireless-next.git, thanks.
8b860466b137 wifi: atmel: Fix atmel_private_handler array size
--
https://patchwork.kernel.org/project/linux-wireless/patch/20221018023732.never.700-kees@kernel.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-01 11:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-18 2:37 [PATCH][next] atmel: Fix atmel_private_handler array size Kees Cook
2022-11-01 10:59 ` [next] wifi: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).