From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A67C43217 for ; Thu, 10 Nov 2022 16:29:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231741AbiKJQ3Y (ORCPT ); Thu, 10 Nov 2022 11:29:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231727AbiKJQ3W (ORCPT ); Thu, 10 Nov 2022 11:29:22 -0500 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A5482FFDD for ; Thu, 10 Nov 2022 08:29:21 -0800 (PST) Received: by mail-pl1-x631.google.com with SMTP id y4so1812123plb.2 for ; Thu, 10 Nov 2022 08:29:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :from:to:cc:subject:date:message-id:reply-to; bh=qnovQdeIx+egc+wctWL+zO6cHJ44FnQ3qczpXh6b5Rc=; b=Gwp1kDX1FCipY1yoLpoRT+LKjTgivm7wfhgwGSd+RxZ9DNE5AG3m9vlIgq9mLbP0Mv nQbd8Jt8mHZgthGzGyDe8BU1HvPhBk04H663rBtsiO7WgszATd/0LdyYYXz/0Gpdb7it FEhrmO0m4dENT3TwGhnrL3hBp/C7TXrZIQVZQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qnovQdeIx+egc+wctWL+zO6cHJ44FnQ3qczpXh6b5Rc=; b=R8ZO3iLThgrTHp8+d1TYBM+ULWmwzxzHDhHVBwWwDUrpCnFOgSgsSgd3813i9nDjRN L9CyuN/6Wb9OlLj2D0tS4iLoHBqgH35vQLxLJXM0y3hibH2eqbJp+53j1okt8g/5LXt1 wGXDr7g9pHxXmzT3Bafy+cClCavxYbn6BKhvzretxA8MjZhoutnqvBNr+dwbf2OfR/Vs bUahmNhWKOr5AgO0WYqXFGIoaopcNFYw7tMNdsHZ7rQpaq7ghdO6KUxAtoxFLSoqU+Y9 3ypLaHSWhiqhJVt1XdlhaLTTvzzzD3OWlq/BIRYp4mybbayCTveJvJLyViB902ufP9Tm nnzw== X-Gm-Message-State: ANoB5plpHvFM5/LnYPqVpAvYV6kEDh/s7RwFZIdm1nx1zmLY8dJVANHE NU3alHEfThk5YJ3Jqa8fCqk5hJvyzKeqRg== X-Google-Smtp-Source: AA0mqf4OAxg/aPEkLol3W9r99Ywjc2Hkx53s92PFLJXoZPdWyG8E6OPkaKwZNdmxaRGyPJxvqOAU9Q== X-Received: by 2002:a17:902:ca0d:b0:188:9806:2e05 with SMTP id w13-20020a170902ca0d00b0018898062e05mr4228345pld.112.1668097760798; Thu, 10 Nov 2022 08:29:20 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id nn14-20020a17090b38ce00b00213d28a6dedsm3315459pjb.13.2022.11.10.08.29.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 08:29:20 -0800 (PST) From: coverity-bot X-Google-Original-From: coverity-bot Date: Thu, 10 Nov 2022 08:29:19 -0800 To: Daniel Drake Cc: linux-kernel@vger.kernel.org, "John W. Linville" , linux-wireless@vger.kernel.org, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Kalle Valo , "David S. Miller" , netdev@vger.kernel.org, "Gustavo A. R. Silva" , linux-next@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Coverity: if_sdio_reset_card_worker(): Error handling issues Message-ID: <202211100829.34D7E6894@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221110 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Fri Jun 10 14:57:47 2011 -0400 9a821f5d0fc3 ("libertas: add sd8686 reset_card support") Coverity reported the following: *** CID 1527255: Error handling issues (CHECKED_RETURN) drivers/net/wireless/marvell/libertas/if_sdio.c:1048 in if_sdio_reset_card_worker() 1042 * We run it in a workqueue totally independent from the if_sdio_card 1043 * instance for that reason. 1044 */ 1045 1046 pr_info("Resetting card..."); 1047 mmc_remove_host(reset_host); vvv CID 1527255: Error handling issues (CHECKED_RETURN) vvv Calling "mmc_add_host" without checking return value (as is done elsewhere 27 out of 32 times). 1048 mmc_add_host(reset_host); 1049 } 1050 static DECLARE_WORK(card_reset_work, if_sdio_reset_card_worker); 1051 1052 static void if_sdio_reset_card(struct lbs_private *priv) 1053 { If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot Addresses-Coverity-ID: 1527255 ("Error handling issues") Fixes: 9a821f5d0fc3 ("libertas: add sd8686 reset_card support") Thanks for your attention! -- Coverity-bot